From 64b2ca83bb2aad6c1c293b40dd0b57c16d4699bf Mon Sep 17 00:00:00 2001 From: afc163 Date: Fri, 29 Jul 2016 16:08:42 +0800 Subject: [PATCH] Fix unknown props --- components/badge/ScrollNumber.tsx | 9 ++++++++- package.json | 1 + typings/custom.d.ts | 7 ++++++- 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/components/badge/ScrollNumber.tsx b/components/badge/ScrollNumber.tsx index 8be34c0181..dbaae4cc46 100644 --- a/components/badge/ScrollNumber.tsx +++ b/components/badge/ScrollNumber.tsx @@ -3,6 +3,7 @@ import * as React from 'react'; import {findDOMNode} from 'react-dom'; import isCssAnimationSupported from '../_util/isCssAnimationSupported'; import assign from 'object-assign'; +import omit from 'object-omit'; function getNumberArray(num) { return num ? @@ -124,7 +125,13 @@ export default class ScrollNumber extends React.Component { } render() { - const props = assign({}, this.props, { + // fix https://fb.me/react-unknown-prop + const props = assign({}, omit(this.props, [ + 'count', + 'onAnimated', + 'component', + 'prefixCls', + ]), { className: `${this.props.prefixCls} ${this.props.className}`, }); return createElement( diff --git a/package.json b/package.json index f00d8bc048..05dec13b6a 100644 --- a/package.json +++ b/package.json @@ -33,6 +33,7 @@ "moment": "^2.14.1", "normalize.css": "~4.2.0", "object-assign": "~4.1.0", + "object-omit": "^1.0.0", "rc-animate": "~2.3.0", "rc-checkbox": "~1.4.0", "rc-collapse": "~1.6.6", diff --git a/typings/custom.d.ts b/typings/custom.d.ts index 3919486f3f..87b90039d8 100644 --- a/typings/custom.d.ts +++ b/typings/custom.d.ts @@ -81,6 +81,11 @@ declare module 'object-assign' { export default exports } +declare module 'object-omit' { + var exports: any + export default exports +} + declare module 'rc-input-number' { var exports: any export default exports @@ -156,7 +161,7 @@ declare module 'react-native-camera-roll-picker' { var exports: any export default exports } - + declare module 'react-timer-mixin'{ var exports: any export default exports