New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass `successPercent` to `format` prop on `Progress` Component. #10096

Closed
joshuapinter opened this Issue Apr 16, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@joshuapinter

joshuapinter commented Apr 16, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

The Progress Component can accept a successPercent prop to show a segment of the total progress that is complete or "successful". However, this successPercent is not passed to the format prop function so it can not currently be used to display a custom format. Only the percent value is passed to the format prop function.

What does the proposed API look like?

I would pass the successPercent as a second parameter to the format prop function. This way it can optionally be accessed. It would look something like this:

<Progress 
  percent={60} 
  successPercent={30} 
  format={ (percent, successPercent) => successPercent + "% Efficient" />
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment