/ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `theme` props to `Layout.Sider` #10142

Closed
pd4d10 opened this Issue Apr 18, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
4 participants
@pd4d10 @jamesriady @tastypackets @afc163
@pd4d10
Contributor

pd4d10 commented Apr 18, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Menu has a theme props(light or dark), while Layout.Sider doesn't. It is weird in this case if code is like this:

<Sider><Menu theme="light"></Menu></Sider>

The trigger is always dark.

What does the proposed API look like?

Add a props named theme to Layout.Sider, with value dark or light

Willing to submit a PR if you have the plan.

@afc163 afc163 added Accept good first issue labels Apr 22, 2018

pd4d10 added a commit to pd4d10/ant-design that referenced this issue Apr 22, 2018

@pd4d10
Fix ant-design#10142: Add `theme` props to `Layout.Sider`
73ca2c6

pd4d10 added a commit to pd4d10/ant-design that referenced this issue Apr 22, 2018

@pd4d10
Fix ant-design#10142: Add `theme` props to `Layout.Sider`
dee517c
@jamesriady

This comment has been minimized.

Sign in to view

jamesriady commented Apr 24, 2018

how to add new theme color in menu? it's only has two theme.. dark & light.. I want to add more

@pd4d10 pd4d10 referenced this issue Apr 26, 2018

Closed

[WIP] Fix #10142: Add `theme` props to `Layout.Sider` #10186

6 of 9 tasks complete
@tastypackets

This comment has been minimized.

Sign in to view
Contributor

tastypackets commented May 21, 2018

This would be handy, was the PR closed due to not completing all tasks or something else?

@jamesriady I think you are looking for this information about making a custom theme: https://ant.design/docs/react/customize-theme

pd4d10 added a commit to pd4d10/ant-design that referenced this issue May 23, 2018

@pd4d10
Fix ant-design#10142: Add `theme` props to `Layout.Sider`
9b44ef7

@pd4d10 pd4d10 referenced this issue May 23, 2018

Merged

Fix #10142: Add `theme` props to `Layout.Sider` #10631

9 of 9 tasks complete

@picodoth picodoth closed this in f386927 Jun 2, 2018

bors bot added a commit to mozilla/delivery-console that referenced this issue Jun 4, 2018

@bors[bot] @renovate-bot
Merge #177 
177: Update dependency antd to v3.6.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.4` to `v3.6.1`



<details>
<summary>Release Notes</summary>

### [`v3.6.1`](https://github.com/ant-design/ant-design/releases/3.6.1)
[Compare Source](ant-design/ant-design@3.6.0...3.6.1)
* 🐞 修复一个 Typescript 的编译错误。

---

* 🐞 Fixing a Typescript compilation error.

---

### [`v3.6.0`](https://github.com/ant-design/ant-design/releases/3.6.0)
[Compare Source](ant-design/ant-design@3.5.4...3.6.0)
* 🌟 `Form`'s error message now can be customized with ReactNode. [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` support customized configuration for position of pagination. [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` now can be configured with `light` or `dark` theme. [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 Ant Design official site now supports offline mode. [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` adding `style` and `operationStyle` props for further customization. [@&#8203;eduludi]
* 🌟 `Message` adds a promisfied interface to handle callback. [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 Fix compilation issue with typescript@&#8203;v2.9.1 . [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 Fix a bug in `Menu` where outer menu item not highlighting while inner item is selected. [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 Affix `offsetBottom` not working. [#&#8203;10674](`ant-design/ant-design#10674)

---

* 🌟 `Form` 表单错误信息展示支持传入 ReactNode。 [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` 组件支持指定分页器的位置。 [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` 支持 dark/light 主题定制。 [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 支持 Ant Design 站点的离线模式。 [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` 新增 `style` 以及 `operationStyle` 属性配置样式。 [@&#8203;eduludi]
* 🌟 `Message` 增加 promise 化的回调接口。 [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 修复编译时 typescript v2.9.1兼容性问题。 [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 修复 `Menu` 嵌套超过两层时选中最里层后对应最外层没有亮起问题。 [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 修复 `Affix` 组件 offsetBottom 无效问题。 [#&#8203;10674](`ant-design/ant-design#10674)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Loading status checks…
433906f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment