Add `theme` props to `Layout.Sider` #10142
Closed
Labels
Comments
|
how to add new theme color in |
|
This would be handy, was the PR closed due to not completing all tasks or something else? @jamesriady I think you are looking for this information about making a custom theme: https://ant.design/docs/react/customize-theme |
bors bot
added a commit
to mozilla/delivery-console
that referenced
this issue
Jun 4, 2018
177: Update dependency antd to v3.6.1 r=rehandalal a=renovate[bot] This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.4` to `v3.6.1` <details> <summary>Release Notes</summary> ### [`v3.6.1`](https://github.com/ant-design/ant-design/releases/3.6.1) [Compare Source](ant-design/ant-design@3.6.0...3.6.1) *🐞 修复一个 Typescript 的编译错误。 --- *🐞 Fixing a Typescript compilation error. --- ### [`v3.6.0`](https://github.com/ant-design/ant-design/releases/3.6.0) [Compare Source](ant-design/ant-design@3.5.4...3.6.0) *🌟 `Form`'s error message now can be customized with ReactNode. [#​10136](`ant-design/ant-design#10136) [@​lovekonakona] *🌟 `List` support customized configuration for position of pagination. [#​10581](`ant-design/ant-design#10581) [@​zheeeng] *🌟 `Layout.Sider` now can be configured with `light` or `dark` theme. [#​10142](`ant-design/ant-design#10142) [@​pd4d10] *🌟 Ant Design official site now supports offline mode. [#​10625](`ant-design/ant-design#10625) *🌟 `Transfer` adding `style` and `operationStyle` props for further customization. [@​eduludi] *🌟 `Message` adds a promisfied interface to handle callback. [#​10421](`ant-design/ant-design#10421) [@​zhujinxuan] *🐞 Fix compilation issue with typescript@​v2.9.1 . [#​10729](`ant-design/ant-design#10729) [@​karol-majewski] *🐞 Fix a bug in `Menu` where outer menu item not highlighting while inner item is selected. [#​8666](`ant-design/ant-design#8666) [@​stonehank] *🐞 Affix `offsetBottom` not working. [#​10674](`ant-design/ant-design#10674) --- *🌟 `Form` 表单错误信息展示支持传入 ReactNode。 [#​10136](`ant-design/ant-design#10136) [@​lovekonakona] *🌟 `List` 组件支持指定分页器的位置。 [#​10581](`ant-design/ant-design#10581) [@​zheeeng] *🌟 `Layout.Sider` 支持 dark/light 主题定制。 [#​10142](`ant-design/ant-design#10142) [@​pd4d10] *🌟 支持 Ant Design 站点的离线模式。 [#​10625](`ant-design/ant-design#10625) *🌟 `Transfer` 新增 `style` 以及 `operationStyle` 属性配置样式。 [@​eduludi] *🌟 `Message` 增加 promise 化的回调接口。 [#​10421](`ant-design/ant-design#10421) [@​zhujinxuan] *🐞 修复编译时 typescript v2.9.1兼容性问题。 [#​10729](`ant-design/ant-design#10729) [@​karol-majewski] *🐞 修复 `Menu` 嵌套超过两层时选中最里层后对应最外层没有亮起问题。 [#​8666](`ant-design/ant-design#8666) [@​stonehank] *🐞 修复 `Affix` 组件 offsetBottom 无效问题。 [#​10674](`ant-design/ant-design#10674) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What problem does this feature solve?
Menuhas athemeprops(lightordark), whileLayout.Siderdoesn't. It is weird in this case if code is like this:The trigger is always dark.
What does the proposed API look like?
Add a props named
themetoLayout.Sider, with valuedarkorlightWilling to submit a PR if you have the plan.
The text was updated successfully, but these errors were encountered: