New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider renders incorrectly with setting orientation and dashed at the same time #10216

Closed
zheeeng opened this Issue Apr 24, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@zheeeng
Contributor

zheeeng commented Apr 24, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.4.3

Environment

React 16.3

Reproduction link

https://codepen.io/zheeeng/pen/mLVZxv

Steps to reproduce

Check the reproduction

What is expected?

Text is positioned by orientation and only dashed line are rendered.

What is actually happening?

Dashed line and solid line are both rendered.

@yutingzhao1991 yutingzhao1991 referenced this issue Apr 24, 2018

Closed

Fix #10216 #10219

5 of 10 tasks complete

@afc163 afc163 self-assigned this Apr 24, 2018

@afc163 afc163 added the Bug🐛 label Apr 24, 2018

@afc163 afc163 closed this in a268dc8 Apr 24, 2018

@zheeeng

This comment has been minimized.

Contributor

zheeeng commented Apr 24, 2018

Oh, I have already created a PR for this issue. #10219

And is appended on the issue timeline.

@afc163

This comment has been minimized.

Member

afc163 commented Apr 25, 2018

Sorry to duplicate your job, didn't notice that~ 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment