New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkbox style: .ant-checkbox-input should not have a z-index #10385

Closed
Nouzbe opened this Issue May 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@Nouzbe

Nouzbe commented May 6, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.5.0

Environment

Windows 10.0.16299, Chrome 66.0.3359.139, React 16.3.2

Reproduction link

http://jsfiddle.net/3cwzj0ea/144/

Steps to reproduce

As shown in the jsfiddle, use antd.Checkbox and have a absolutely positioned div rendered on top of it

What is expected?

The checkbox should not appear on top of the overlay.

What is actually happening?

The checkbox does appear on top of the overlay.


This can easily be fixed on the project side, but it implies having z-index >= 2 on every overlay, which is dirty.

The problem is caused by components/checkbox/style/mixin.less#L72.

This issue might be related to ant-design/issues/9840.

@afc163 afc163 closed this in d93cfde May 6, 2018

bors bot added a commit to mozilla/delivery-console that referenced this issue May 10, 2018

Merge #158
158: Update dependency antd to v3.5.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.0` to `v3.5.1`



<details>
<summary>Release Notes</summary>

### [`v3.5.1`](https://github.com/ant-design/ant-design/releases/3.5.1)
[Compare Source](ant-design/ant-design@3.5.0...3.5.1)
- 🐞 Fixed broken style of Input.Group under Form. [#&#8203;10371](`ant-design/ant-design#10371)
- 🐞 Fixed overlay style of Select. [#&#8203;10383](`ant-design/ant-design#10383)
- 🐞 Remove focused style of Collapse.
- 🐞 Remove unnecessary `z-index` of Input.Group and Checkbox. [#&#8203;9840](`ant-design/ant-design#9840) [#&#8203;10385](`ant-design/ant-design#10385)
- 🐞 Fixed that monospaced font family can't be bold.
- Table
  - 💄 Rewrited the editable table demo. [#&#8203;10119](`ant-design/ant-design#10119)
  - 🐞 Fixed that table column overlay each other. [#&#8203;9822](`ant-design/ant-design#9822)
- TypeScript
  - 🐞 Fixed Breadcrumb.Item type. [#&#8203;10372](`ant-design/ant-design#10372) [@&#8203;karol-majewski]
  - 🐞 Fixed Table `rowSelection` type。[#&#8203;10374](`ant-design/ant-design#10374)


---


- 🐞 修复 Input.Group 在 Form 下样式错位的问题。[#&#8203;10371](`ant-design/ant-design#10371)
- 🐞 修复 Select 箭头和内容重叠的问题。[#&#8203;10383](`ant-design/ant-design#10383)
- 🐞 移除 Collapse 点击时的 focus 样式。
- 🐞 移除 Input.Group 和 Checkbox 不必要的 `z-index`。[#&#8203;9840](`ant-design/ant-design#9840) [#&#8203;10385](`ant-design/ant-design#10385)
- 🐞 修复一个数字等宽字体没有加粗的问题。
- Table
  - 💄 重写了可编辑表格的演示。[#&#8203;10119](`ant-design/ant-design#10119)
  - 🐞 修复一个表格列内容互相重叠的问题。[#&#8203;9822](`ant-design/ant-design#9822)
- TypeScript
  - 🐞 调整 Breadcrumb.Item 的类型。[#&#8203;10372](`ant-design/ant-design#10372) [@&#8203;karol-majewski]
  - 🐞 修复 Table 的 `rowSelection` 的类型。[#&#8203;10374](`ant-design/ant-design#10374)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>

afc163 added a commit that referenced this issue May 18, 2018

@afc163

This comment has been minimized.

Member

afc163 commented May 18, 2018

Turns out z-index in Checkbox is useful, removing it caused #10452 and #10480 so I just reverted the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment