Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table filter doesn't work on checkbox click #10452

Closed
1 task done
shivamgupta94 opened this issue May 9, 2018 · 4 comments
Closed
1 task done

Table filter doesn't work on checkbox click #10452

shivamgupta94 opened this issue May 9, 2018 · 4 comments
Assignees
@afc163
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@shivamgupta94
Copy link

shivamgupta94 commented May 9, 2018 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.5.1

Environment

Windows 8, Chrome Version 66.0.3359.139 (Official Build) (64-bit)

Reproduction link

https://ant.design/components/table/#components-table-demo-head

Steps to reproduce

See link of example on the ant design page (https://ant.design/components/table/#components-table-demo-head)
The filter works on clicking the text, but not by clicking the checkbox

What is expected?

Works when checkbox is clicked

What is actually happening?

Works only when the filter popup text is clicked

Probably something broke in the latest build. It worked fine about a month ago.
@afc163 afc163 self-assigned this May 10, 2018
@afc163 afc163 added the 🐛 Bug Ant Design Team had proved that this is a bug. label May 10, 2018
@afc163
Copy link
Member

afc163 commented May 10, 2018

@picodoth Look up this problem, it will trigger twice Menu[onClick] when click Checkbox.

1

@shivamgupta94
Copy link
Author

It works when you click on the menu text. But it doesn't work when the check box is clicked.
Just providing further context.

@picodoth
Copy link
Contributor

working on this

picodoth referenced this issue May 10, 2018
@picodoth
fix: checkbox trigger twice
030c745 
regression introduced from d93cfde
This was referenced May 11, 2018
Closed
Closed
bors bot added a commit to mozilla/delivery-console that referenced this issue May 14, 2018
@bors @renovate-bot
Merge #160
6c953db 
160: Update dependency antd to v3.5.2 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.1` to `v3.5.2`



<details>
<summary>Release Notes</summary>

### [`v3.5.2`](https://github.com/ant-design/ant-design/releases/3.5.2)
[Compare Source](ant-design/ant-design@3.5.1...3.5.2)
- 🐞 Fixed `Cascader` displayRender z-index issue. [#&#8203;10433](`ant-design/ant-design#10433)
- 🐞 Fixed `Button` Types of property 'ref' are incompatible. [#&#8203;10405](`ant-design/ant-design#10405)
- 🐞 Fixed `Table` filter doesn't work on checkbox click. [#&#8203;10452](`ant-design/ant-design#10452)
- 🐞 Fixed the height of `Form` item when checks position is dithered. [#&#8203;10445](`ant-design/ant-design#10445)
- 🌟 Allow to use any CSS units for `Layout` width. [#&#8203;10479](`ant-design/ant-design#10479)


---


- 🐞 修复 `Cascader` 的 displayRender 问题。[#&#8203;10433](`ant-design/ant-design#10433)
- 🐞 修复 `Button` ref 不兼容问题。[#&#8203;10405](`ant-design/ant-design#10405)
- 🐞 修复 `Table` 过滤器在复选框上不起作用。[#&#8203;10452](`ant-design/ant-design#10452)
- 🐞 修复 `Form` 表单项校验位置高度时出现抖动问题。[#&#8203;10445](`ant-design/ant-design#10445)
- 🌟 设置 `Layout` 宽度时，允许使用任何的 CSS 单位。 [#&#8203;10479](`ant-design/ant-design#10479)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@afc163
Copy link
Member

afc163 commented May 17, 2018

Should be fixed in

@afc163 afc163 closed this as completed May 17, 2018
afc163 added a commit that referenced this issue May 18, 2018
@afc163
fix: Revert checkbox z-index
7c4f6e8 
fix #10480

ref #10452

reverted for #10385
@afc163 afc163 mentioned this issue May 18, 2018
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afc163 afc163

Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@afc163 @picodoth @shivamgupta94