New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition of dataSource for AutoComplete is wrong #10619

Closed
irrigator opened this Issue May 22, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@irrigator
Contributor

irrigator commented May 22, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.5.3

Environment

macOS 10.13.4, Chrome 66.0.3359.181, React 16.3.2, TypeScript 2.8

Reproduction link

https://gist.github.com/irrigator/e65fe5e57eaa5fb1a097ee01b64636db

Steps to reproduce

Compile the Lookup-Patterns example of AutoComplete in TypeScript, or just pass an array of AutoComplete to the dataSource prop.

What is expected?

It should compile.

What is actually happening?

Type error because type of dataSource is (string | { value: string, text: string }[], which is wrong.

@yesmeck yesmeck closed this in 4d6f8e9 Jun 9, 2018

bors bot added a commit to mozilla/delivery-console that referenced this issue Jun 11, 2018

Merge #189
189: Update dependency antd to v3.6.2 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.6.1` to `v3.6.2`



<details>
<summary>Release Notes</summary>

### [`v3.6.2`](https://github.com/ant-design/ant-design/releases/3.6.2)
[Compare Source](ant-design/ant-design@70ca028...3.6.2)
- 🐞 Fix the wrong status of check all checkbox in Table when data change. [#&#8203;10629](`ant-design/ant-design#10629)
- 🐞 Fix border style of Button.Group.
- 🐞 Fix file list being reversed when `beforeUpload` returns `false` in Upload component. [#&#8203;10681](`ant-design/ant-design#10681)
- 🐞 Fix overflow of cell content in Calendar. [#&#8203;10808](`ant-design/ant-design#10808) [@&#8203;Yangzhedi](https://github.com/ant-design/Yangzhedi)
- 🐞 Fix the processing color of Badge not follows the `primary-color`.
- Spin
  - 🐞 Fix custom icon does not follow the value of `size`. [#&#8203;10786](`ant-design/ant-design#10786)
  - 🐞 Fix no `delay` issue when sets `spinning` to `true` as default.[#&#8203;10727](`ant-design/ant-design#10727) [@&#8203;dreamerblue]
- TypeScript
  - 🐞 Fix Menu type definition. [#&#8203;10773](`ant-design/ant-design#10773)
  - 🐞 Fix AutoComplete type definition. [#&#8203;10745](`ant-design/ant-design#10745) [#&#8203;10619](`ant-design/ant-design#10619)
  - 🐞 Fix Tree type definition. [#&#8203;10841](`ant-design/ant-design#10841) [@&#8203;Voronar]
  - 🐞 Fix Checkbox.Group definition. [#&#8203;10677](`ant-design/ant-design#10677)


---


- 🐞 修复 Table 数据变化时全选勾选框状态显示不正确的问题。[#&#8203;10629](`ant-design/ant-design#10629)
- 🐞 修复 Button.Group 中使用 disabled 按钮时缺失边框。
- 🐞 修复 Upload 中 `beforeUpload` 返回 `false` 时,文件列表排序会被反转的问题。[#&#8203;10681](`ant-design/ant-design#10681)
- 🐞 修复 Calendar 表格中内容溢出的问题。[#&#8203;10808](`ant-design/ant-design#10808) [@&#8203;Yangzhedi](https://github.com/ant-design/Yangzhedi)
- Spin
  - 🐞 修复使用图标时不能按照 `size` 正确显示大小的问题。[#&#8203;10786](`ant-design/ant-design#10786)
  - 🐞 修复默认旋转时 `delay` 不生效的问题。[#&#8203;10727](`ant-design/ant-design#10727) [@&#8203;dreamerblue]
- 修复 Badge 的状态色不跟主题色变化的问题。
- TypeScript
  - 🐞 修复 Menu 类型定义。[#&#8203;10773](`ant-design/ant-design#10773)
  - 🐞 修复 AutoComplete 类型定义。[#&#8203;10745](`ant-design/ant-design#10745) [#&#8203;10619](`ant-design/ant-design#10619)
  - 🐞 修复 Tree 类型定义。[#&#8203;10841](`ant-design/ant-design#10841) [@&#8203;Voronar]
  - 🐞 修复 Checkbox.Group 的类型定义。[#&#8203;10677](`ant-design/ant-design#10677)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment