New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incopatible type with typescript v2.9.1 #10729

Closed
saostad opened this Issue May 31, 2018 · 3 comments

Comments

Projects
None yet
5 participants
@saostad

saostad commented May 31, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.5.4

Environment

bowser 3.5.4

Reproduction link

Edit on CodeSandbox

Steps to reproduce

npm start

What is expected?

compile successfully

What is actually happening?

Error:
antd\lib_util\type.d.ts
(8,63): error TS2344: Type 'keyof T' does not satisfy the constraint 'string'.
Type 'string | number | symbol' is not assignable to
type 'string'.
Type 'number' is not assignable to type 'string'.

@webKity

This comment has been minimized.

webKity commented Jun 1, 2018

me too

@silverbolt

This comment has been minimized.

silverbolt commented Jun 1, 2018

you can use typescript@2.8.4 before fixed

@karol-majewski

This comment has been minimized.

Contributor

karol-majewski commented Jun 1, 2018

#10730 will fix the issue for Ant consumers.

To ensure full compliance within the project one additional thing has to be taken care of: trailing commas in rest parameters. TypeScript 2.9 doesn't allow them, but there are to be found in the repository. This will require a change in this upstream repository:

https://github.com/ant-design/antd-tools/blob/master/lib/tslint.json#L93-L99

@yesmeck yesmeck closed this in 7c27391 Jun 1, 2018

@afc163 afc163 referenced this issue Jun 1, 2018

Merged

Fix #10729 #10730

5 of 5 tasks complete

bors bot added a commit to mozilla/delivery-console that referenced this issue Jun 4, 2018

Merge #177
177: Update dependency antd to v3.6.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.4` to `v3.6.1`



<details>
<summary>Release Notes</summary>

### [`v3.6.1`](https://github.com/ant-design/ant-design/releases/3.6.1)
[Compare Source](ant-design/ant-design@3.6.0...3.6.1)
* 🐞 修复一个 Typescript 的编译错误。

---

* 🐞 Fixing a Typescript compilation error.

---

### [`v3.6.0`](https://github.com/ant-design/ant-design/releases/3.6.0)
[Compare Source](ant-design/ant-design@3.5.4...3.6.0)
* 🌟 `Form`'s error message now can be customized with ReactNode. [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` support customized configuration for position of pagination. [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` now can be configured with `light` or `dark` theme. [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 Ant Design official site now supports offline mode. [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` adding `style` and `operationStyle` props for further customization. [@&#8203;eduludi]
* 🌟 `Message` adds a promisfied interface to handle callback. [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 Fix compilation issue with typescript@&#8203;v2.9.1 . [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 Fix a bug in `Menu` where outer menu item not highlighting while inner item is selected. [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 Affix `offsetBottom` not working. [#&#8203;10674](`ant-design/ant-design#10674)

---

* 🌟 `Form` 表单错误信息展示支持传入 ReactNode。 [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` 组件支持指定分页器的位置。 [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` 支持 dark/light 主题定制。 [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 支持 Ant Design 站点的离线模式。 [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` 新增 `style` 以及 `operationStyle` 属性配置样式。 [@&#8203;eduludi]
* 🌟 `Message` 增加 promise 化的回调接口。 [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 修复编译时 typescript v2.9.1兼容性问题。 [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 修复 `Menu` 嵌套超过两层时选中最里层后对应最外层没有亮起问题。 [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 修复 `Affix` 组件 offsetBottom 无效问题。 [#&#8203;10674](`ant-design/ant-design#10674)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment