New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't compile with TypeScript 2.8.4 #10773

Closed
whtsky opened this Issue Jun 5, 2018 · 6 comments

Comments

Projects
None yet
5 participants
@whtsky
Contributor

whtsky commented Jun 5, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.6.1

Environment

TypeScript 2.8.4

Reproduction link

https://github.com/whtsky/antd-3.6.1-ts-2.8.4-compile-error

Steps to reproduce

yarn start

What is expected?

success

What is actually happening?

ERROR in [at-loader] ./node_modules/antd/lib/menu/index.d.ts:56:22
TS1005: ';' expected.

ERROR in [at-loader] ./node_modules/antd/lib/menu/index.d.ts:56:23
TS1003: Identifier expected.

ERROR in [at-loader] ./node_modules/antd/lib/menu/index.d.ts:56:41
TS1005: ';' expected.

ERROR in [at-loader] ./node_modules/antd/lib/menu/index.d.ts:56:16
TS2304: Cannot find name 'import'.


https://travis-ci.com/whtsky/antd-3.6.1-ts-2.8.4-compile-error/builds/75328387

@yesmeck yesmeck added the help wanted label Jun 5, 2018

@yesmeck

This comment has been minimized.

Member

yesmeck commented Jun 5, 2018

Weird, ts compiled 'light' as MenuTheme to theme: import("../layout/Sider").SiderTheme;

@whtsky

This comment has been minimized.

Contributor

whtsky commented Jun 5, 2018

downgrade to typescript 2.8.4 seems to fix this.

@whtsky whtsky referenced this issue Jun 5, 2018

Closed

fix: downupgrade typescript to 2.8.4 #10778

0 of 10 tasks complete
@bow3nwang

This comment has been minimized.

bow3nwang commented Jun 6, 2018

antd@3.6.1,react-scripts-ts@2.13.0 getting this error.

antd\lib\menu\index.d.ts
(56,22): error TS1005: ';' expected.
@duhongjun

This comment has been minimized.

Contributor

duhongjun commented Jun 6, 2018

same as above

@whtsky

This comment has been minimized.

Contributor

whtsky commented Jun 7, 2018

@zombieJ can you release a patch version for this?

@zombieJ

This comment has been minimized.

Member

zombieJ commented Jun 7, 2018

@whtsky, we will release this weekend.
@yesmeck

bors bot added a commit to mozilla/delivery-console that referenced this issue Jun 11, 2018

Merge #189
189: Update dependency antd to v3.6.2 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.6.1` to `v3.6.2`



<details>
<summary>Release Notes</summary>

### [`v3.6.2`](https://github.com/ant-design/ant-design/releases/3.6.2)
[Compare Source](ant-design/ant-design@70ca028...3.6.2)
- 🐞 Fix the wrong status of check all checkbox in Table when data change. [#&#8203;10629](`ant-design/ant-design#10629)
- 🐞 Fix border style of Button.Group.
- 🐞 Fix file list being reversed when `beforeUpload` returns `false` in Upload component. [#&#8203;10681](`ant-design/ant-design#10681)
- 🐞 Fix overflow of cell content in Calendar. [#&#8203;10808](`ant-design/ant-design#10808) [@&#8203;Yangzhedi](https://github.com/ant-design/Yangzhedi)
- 🐞 Fix the processing color of Badge not follows the `primary-color`.
- Spin
  - 🐞 Fix custom icon does not follow the value of `size`. [#&#8203;10786](`ant-design/ant-design#10786)
  - 🐞 Fix no `delay` issue when sets `spinning` to `true` as default.[#&#8203;10727](`ant-design/ant-design#10727) [@&#8203;dreamerblue]
- TypeScript
  - 🐞 Fix Menu type definition. [#&#8203;10773](`ant-design/ant-design#10773)
  - 🐞 Fix AutoComplete type definition. [#&#8203;10745](`ant-design/ant-design#10745) [#&#8203;10619](`ant-design/ant-design#10619)
  - 🐞 Fix Tree type definition. [#&#8203;10841](`ant-design/ant-design#10841) [@&#8203;Voronar]
  - 🐞 Fix Checkbox.Group definition. [#&#8203;10677](`ant-design/ant-design#10677)


---


- 🐞 修复 Table 数据变化时全选勾选框状态显示不正确的问题。[#&#8203;10629](`ant-design/ant-design#10629)
- 🐞 修复 Button.Group 中使用 disabled 按钮时缺失边框。
- 🐞 修复 Upload 中 `beforeUpload` 返回 `false` 时,文件列表排序会被反转的问题。[#&#8203;10681](`ant-design/ant-design#10681)
- 🐞 修复 Calendar 表格中内容溢出的问题。[#&#8203;10808](`ant-design/ant-design#10808) [@&#8203;Yangzhedi](https://github.com/ant-design/Yangzhedi)
- Spin
  - 🐞 修复使用图标时不能按照 `size` 正确显示大小的问题。[#&#8203;10786](`ant-design/ant-design#10786)
  - 🐞 修复默认旋转时 `delay` 不生效的问题。[#&#8203;10727](`ant-design/ant-design#10727) [@&#8203;dreamerblue]
- 修复 Badge 的状态色不跟主题色变化的问题。
- TypeScript
  - 🐞 修复 Menu 类型定义。[#&#8203;10773](`ant-design/ant-design#10773)
  - 🐞 修复 AutoComplete 类型定义。[#&#8203;10745](`ant-design/ant-design#10745) [#&#8203;10619](`ant-design/ant-design#10619)
  - 🐞 修复 Tree 类型定义。[#&#8203;10841](`ant-design/ant-design#10841) [@&#8203;Voronar]
  - 🐞 修复 Checkbox.Group 的类型定义。[#&#8203;10677](`ant-design/ant-design#10677)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment