Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable feature for card tabs #11212

Closed
1 task done
hemanthvrm opened this issue Jul 9, 2018 · 2 comments
Closed
1 task done

Disable feature for card tabs #11212

hemanthvrm opened this issue Jul 9, 2018 · 2 comments
Assignees

Comments

@hemanthvrm
Copy link

hemanthvrm commented Jul 9, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Tabs feature has disabled option whereas card tabs don't have any.

What does the proposed API look like?

Adding disabled key to tablist prop for cards will solve the issue.
Right now tablist accepting only Array<{key: string, tab: ReactNode}>
const tabListNoTitle = [{
  key: 'article',
  tab: 'article',
 disabled : true
}, {
  key: 'app',
  tab: 'app',
disabled : false
}, {
  key: 'project',
  tab: 'project',
 disabled : false
}]
@afc163 afc163 closed this as completed in 152cae4 Jul 16, 2018
bors bot added a commit to mozilla/delivery-console that referenced this issue Jul 23, 2018
317: Update dependency antd to v3.7.1 r=magopian a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.7.0` to `v3.7.1`



<details>
<summary>Release Notes</summary>

### [3.7.1](https://github.com/ant-design/ant-design/releases/3.7.1)
[Compare Source](ant-design/ant-design@3.7.0...3.7.1)
- 🐞 Fix popup content can't display in Drawer component.[#&#8203;11304](`ant-design/ant-design#11304)
- 🐞 Card using `tabList` support `disabled` prop.[#&#8203;11212](`ant-design/ant-design#11212)
- 🐞 Fix Link of Anchor not sync when `href` update.[#&#8203;11287](`ant-design/ant-design#11287) [@&#8203;tangjinzhou]
- 🐞 Fix Menu component style.[#&#8203;11299](`ant-design/ant-design#11299)
- 🐞 Fix Drawer component don't have animation when `destroyOnClose` is set.[#&#8203;11307](`ant-design/ant-design#11307)
- 🐞 Fix DirectoryTree can't expand when `expandedKeys` is in control.[#&#8203;11366](`ant-design/ant-design#11366)
- 🐞 Fix Button with Tooltip under ButtonGroup style issue when Button is `disabled`.[11321](`ant-design/ant-design#11321) [@&#8203;tangjinzhou]


---


- 🐞 修复 Drawer 内无法显示弹层组件的问题。[#&#8203;11304](`ant-design/ant-design#11304)
- 🐞 带页签的卡片页签支持 disabled 属性。[#&#8203;11212](`ant-design/ant-design#11212)
- 🐞 修复锚点链接组件 href 改变不更新的问题。 [#&#8203;11287](`ant-design/ant-design#11287) [@&#8203;tangjinzhou]
- 🐞 修复 Menu 样式细节问题。[#&#8203;11299](`ant-design/ant-design#11299)
- 🐞 修复 Drawer 组件设置 `destroyOnClose` 后关闭动画消失。[#&#8203;11307](`ant-design/ant-design#11307)
- 🐞 修复 DirectoryTree 在 `expandedKeys` 属性可控时点击无法展开的问题。[#&#8203;11366](`ant-design/ant-design#11366)
- 🐞 修复 ButtonGroup 中使用 Tooltip 的 Button 在 `disabled` 时样式不正确的问题。[11321](`ant-design/ant-design#11321) [@&#8203;tangjinzhou]

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@vadymhimself
Copy link

@hemanthvrm i believe there has to be an option to add a tooltip or other user message to display the reason for disabling the tab. Can you kindly advise how to accomplish this?

@hemanthvrm
Copy link
Author

hemanthvrm commented Mar 13, 2024

@vadymhimself

firstly i requested for tab disabling feature long back when it is not available ,
Just now verified in latest version of ANTd that card is taking tabs component as prop, so in new version it is solved.

If you want tooltip on why the tab is disabled then you have to write your logic since it is not a generic usecase which will be helpful for everyone.

Solution:
Label prop accepts react node , so you can include your tooltip component in label prop.

ex:

{
key: “1”,
disabled: true,
label : <><Tooltip title=“i am disabled reason”>Tab title </>

}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants