Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is the drawer zindex too big? #11304

Closed
lucaslz2020 opened this issue Jul 17, 2018 · 6 comments
Closed

Is the drawer zindex too big? #11304

lucaslz2020 opened this issue Jul 17, 2018 · 6 comments
Assignees

Comments

@lucaslz2020
Copy link

@lucaslz2020 lucaslz2020 commented Jul 17, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.7.0

Environment

react 16.2.0

Reproduction link

https://ant.design/components/drawer-cn/

Steps to reproduce

Click create, owner, DateTime, etc. will not display correctly.

What is expected?

Other pop-up windows can be used normally

What is actually happening?

  • drawer: z-index: 99999;
  • Causes other components with pop-up windows to have problems.
@afc163
Copy link
Member

@afc163 afc163 commented Jul 17, 2018

Should be same as Modal.

@kennylbj
Copy link

@kennylbj kennylbj commented Jul 17, 2018

Another issue for Drawer: Prop destroyOnClose prevents the closing animation of drawer.
The code pen link is same to official demo except line 33( add destroyOnClose prop).

@yesmeck
Copy link
Member

@yesmeck yesmeck commented Jul 17, 2018

@kennylbj Could you create a separate issue?

@kennylbj
Copy link

@kennylbj kennylbj commented Jul 17, 2018

@chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Jul 17, 2018

fixed in 705e57f

afc163 referenced this issue Jul 18, 2018
@afc163 afc163 mentioned this issue Jul 20, 2018
0 of 1 task complete
afc163 referenced this issue Jul 21, 2018
bors bot added a commit to mozilla/delivery-console that referenced this issue Jul 23, 2018
Merge #317
317: Update dependency antd to v3.7.1 r=magopian a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.7.0` to `v3.7.1`



<details>
<summary>Release Notes</summary>

### [3.7.1](https://github.com/ant-design/ant-design/releases/3.7.1)
[Compare Source](ant-design/ant-design@3.7.0...3.7.1)
- 🐞 Fix popup content can't display in Drawer component.[#&#8203;11304](`ant-design/ant-design#11304)
- 🐞 Card using `tabList` support `disabled` prop.[#&#8203;11212](`ant-design/ant-design#11212)
- 🐞 Fix Link of Anchor not sync when `href` update.[#&#8203;11287](`ant-design/ant-design#11287) [@&#8203;tangjinzhou]
- 🐞 Fix Menu component style.[#&#8203;11299](`ant-design/ant-design#11299)
- 🐞 Fix Drawer component don't have animation when `destroyOnClose` is set.[#&#8203;11307](`ant-design/ant-design#11307)
- 🐞 Fix DirectoryTree can't expand when `expandedKeys` is in control.[#&#8203;11366](`ant-design/ant-design#11366)
- 🐞 Fix Button with Tooltip under ButtonGroup style issue when Button is `disabled`.[11321](`ant-design/ant-design#11321) [@&#8203;tangjinzhou]


---


- 🐞 修复 Drawer 内无法显示弹层组件的问题。[#&#8203;11304](`ant-design/ant-design#11304)
- 🐞 带页签的卡片页签支持 disabled 属性。[#&#8203;11212](`ant-design/ant-design#11212)
- 🐞 修复锚点链接组件 href 改变不更新的问题。 [#&#8203;11287](`ant-design/ant-design#11287) [@&#8203;tangjinzhou]
- 🐞 修复 Menu 样式细节问题。[#&#8203;11299](`ant-design/ant-design#11299)
- 🐞 修复 Drawer 组件设置 `destroyOnClose` 后关闭动画消失。[#&#8203;11307](`ant-design/ant-design#11307)
- 🐞 修复 DirectoryTree 在 `expandedKeys` 属性可控时点击无法展开的问题。[#&#8203;11366](`ant-design/ant-design#11366)
- 🐞 修复 ButtonGroup 中使用 Tooltip 的 Button 在 `disabled` 时样式不正确的问题。[11321](`ant-design/ant-design#11321) [@&#8203;tangjinzhou]

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@AndreiBacescu
Copy link

@AndreiBacescu AndreiBacescu commented Dec 17, 2020

By default, the tooltip is created in body and because the modal is limited to the stacking context of its parent (the parent is nested in body) it will never overlay the tooltip.
More details here: https://coder-coder.com/z-index-isnt-working/

In my opinion, one of the solution for this problem is to use getTooltipPopupContainer property from Slider component and create a DOM container that is at least, on the same level as Slider parent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants