Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getContainer props to Modal.confirm to allow React-Portal in confirmation modal #11377

Closed
gjulivan opened this issue Jul 20, 2018 · 3 comments
Closed
Assignees
Labels

Comments

@gjulivan
Copy link

@gjulivan gjulivan commented Jul 20, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Ability to support React-Portal in Modal.confirm (already supported by modal, but not Modal.confirm), thus, modal can be rendered using React 16's portal

What does the proposed API look like?

const ConfirmDialog = (props) => {
  const { onCancel, onOk, close, zIndex, afterClose, visible, keyboard, getContainer } = props;

  return (
    <Dialog
...
      getContainer={getContainer}
...
    >
@yesmeck
Copy link
Member

@yesmeck yesmeck commented Jul 20, 2018

It's not possible to use React.Portal with current implementation of Modal.confirm.

@gjulivan
Copy link
Author

@gjulivan gjulivan commented Jul 20, 2018

@afc163

This comment was marked as off-topic.

afc163 added a commit that referenced this issue Aug 25, 2018
@afc163 afc163 closed this Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants