Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
add getContainer props to Modal.confirm to allow React-Portal in confirmation modal #11377
What problem does this feature solve?
Ability to support React-Portal in Modal.confirm (already supported by modal, but not Modal.confirm), thus, modal can be rendered using React 16's portal
What does the proposed API look like?
It is supported by rc-dialog already, you just need to pass down the getContainer props down to the dialog, this function will be called by rc-dialog and renders the modal to the given DOM Node by the function. I already use it in ant-modal, just need the props to be pass down as well in Modal.confirm you can see my sample codes above. @yesmeck…
On Fri, 20 Jul 2018, 13:58 Wei Zhu, ***@***.***> wrote: It's not possible to use React.Portal with current implementation of Modal.confirm. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#11377 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXphItVz5hX76Q38-gukwQGQVHRjvgrks5uIXF8gaJpZM4VXfkd> .