New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add getContainer props to Modal.confirm to allow React-Portal in confirmation modal #11377

gjulivan opened this Issue Jul 20, 2018 · 3 comments


None yet
4 participants

gjulivan commented Jul 20, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Ability to support React-Portal in Modal.confirm (already supported by modal, but not Modal.confirm), thus, modal can be rendered using React 16's portal

What does the proposed API look like?

const ConfirmDialog = (props) => {
  const { onCancel, onOk, close, zIndex, afterClose, visible, keyboard, getContainer } = props;

  return (

This comment has been minimized.


yesmeck commented Jul 20, 2018

It's not possible to use React.Portal with current implementation of Modal.confirm.


This comment has been minimized.

gjulivan commented Jul 20, 2018


This comment was marked as off-topic.


afc163 commented Aug 25, 2018

We should make this works.

afc163 added a commit that referenced this issue Aug 25, 2018

@afc163 afc163 closed this Aug 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment