New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Drawer] Bug: Fail to scroll up on mobile #11443

Closed
gudh opened this Issue Jul 24, 2018 · 13 comments

Comments

Projects
None yet
7 participants
@gudh

gudh commented Jul 24, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.7.1

Environment

macOS v10.13.6, Chrome v67.0.3396.99, React ^16.4.1

Reproduction link

https://ant.design/components/drawer/#components-drawer-demo-user-profile

Steps to reproduce

The bug happens with online demo too
check out Preview drawer example
On desktop, it works, however on mobile, it falls to scroll up

What is expected?

On mobile, it should be able to scroll down or up

What is actually happening?

On mobile, you can scroll down but fail to scroll up

@chenshuai2144

This comment has been minimized.

Contributor

chenshuai2144 commented Jul 25, 2018

You can change the width to 320 or 240 and it will be normal.

@gudh

This comment has been minimized.

gudh commented Jul 25, 2018

@chenshuai2144 Thanks for the quick response! Really appreciate it!

May I ask whether it'll be fixed in the next update?

@chenshuai2144

This comment has been minimized.

Contributor

chenshuai2144 commented Jul 25, 2018

He is not a bug, just because the demo is not suitable for display on mobile phones.

@gudh

This comment has been minimized.

gudh commented Aug 3, 2018

@chenshuai2144

Thanks for keeping in touch!

Well, all the online demo fail to scroll up on mobile

Default width is 256px, which fails too

I am a bit confused why it isn't a bug.

Thanks!

@afc163 afc163 reopened this Aug 3, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Aug 3, 2018

@chenshuai2144 We should make sure our components could be accessible at least.

@jljsj33

This comment has been minimized.

Member

jljsj33 commented Aug 3, 2018

???? When the state of drawer is opened, the window is not scrolling, and scroll down may be bug.

jljsj33 added a commit that referenced this issue Aug 3, 2018

@jljsj33 jljsj33 referenced this issue Aug 3, 2018

Closed

[WIP]Update Drawer #11601

3 of 3 tasks complete
@gudh

This comment has been minimized.

gudh commented Aug 5, 2018

@jljsj33 sorry I didn't make this clear

By scrollable, I don't mean the window is scrollable, what I actually mean is the long menu inside the drawer.

Because I have a long menu (overflow: auto) inside the drawer, so it's scrollable

However, on mobile, you can scroll down the menu, but fail to scroll up

The online demos only have short content, but if you add more to make them longer than the drawer, you'll find these content fail to scroll up on mobile too

@jljsj33 jljsj33 reopened this Aug 5, 2018

@IssuehuntBot

This comment has been minimized.

IssuehuntBot commented Aug 6, 2018

@BoostIO funded this issue with $15. Visit this issue on Issuehunt

jljsj33 added a commit that referenced this issue Aug 6, 2018

@shivamgupta94

This comment has been minimized.

shivamgupta94 commented Aug 6, 2018

Agree with @gudh. Facing the same issue. When scrolling on mobile with drawer expanded it causes the background to scroll and not the drawer area.

chenshuai2144 added a commit that referenced this issue Aug 10, 2018

chenshuai2144 added a commit that referenced this issue Aug 10, 2018

@shivamgupta94

This comment has been minimized.

shivamgupta94 commented Aug 15, 2018

Any update on when this will be fixed?

picodoth added a commit that referenced this issue Aug 18, 2018

Fix drawer (#11702)
* fix #11583 #11443 remove pointer-events

* update snap  fix ci

* @ease change to @drawer-easing

* add @ease-base-out and @ease-base-in

* fix drawer

@afc163 afc163 closed this Aug 18, 2018

afc163 added a commit that referenced this issue Aug 22, 2018

@IssuehuntBot

This comment has been minimized.

IssuehuntBot commented Aug 28, 2018

@afc163 has started working. Visit this issue on Issuehunt

@IssuehuntBot

This comment has been minimized.

IssuehuntBot commented Aug 28, 2018

@IssuehuntBot

This comment has been minimized.

IssuehuntBot commented Sep 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment