New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong/odd Italian localization in the DatePicker component #12413

Closed
yp opened this Issue Sep 26, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@yp
Contributor

yp commented Sep 26, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.9.3

Environment

n.a.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  • Use the LocaleProvider with locale it_IT.
  • Render a DatePicker with showTime={true}
  • Open the popup
  • Click on Selezionare il tempo

What is expected?

The first message in the popup should be Seleziona l'ora and the message to go back to the date picker popu should be Seleziona la data.

What is actually happening?

The first message is Seleziona il tempo (which is non-sense in Italian) and the second one is Select date (which is English).


There are several other odd or wrong messages in the Italian localization of the DatePicker component (and the related ones, such as rc-calendar). I can prepare a PR if you find it useful.

@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 26, 2018

Thanks for feedback, since we don't speak Italian, could you help to send a PR for this?

@yp

This comment has been minimized.

Contributor

yp commented Sep 26, 2018

Yes, sure.
Some messages come from rc-calendar. Do you prefer to fix them with a separate PR on that repository or by overwriting them here?

@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 26, 2018

Separate PR, thanks : )

@afc163 afc163 added the help wanted label Oct 6, 2018

@IssuehuntBot

This comment has been minimized.

IssuehuntBot commented Oct 10, 2018

@BoostIO funded this issue with $10. Visit this issue on Issuehunt

yp added a commit to yp/ant-design that referenced this issue Oct 10, 2018

Fix Italian translation (fix ant-design#12413)
* Fix Italian translation.
* Update relevant snapshots.

yp added a commit to yp/ant-design that referenced this issue Oct 10, 2018

Fix Italian translation (fix ant-design#12413)
* Fix Italian translation.
* Update relevant snapshots.

@afc163 afc163 closed this in 150921b Oct 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment