New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Badge is vertically offset #12419

Closed
eduludi opened this Issue Sep 26, 2018 · 4 comments

Comments

Projects
None yet
5 participants
@eduludi
Contributor

eduludi commented Sep 26, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.9.3

Environment

any

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Since v3.9.3, setting a standalone Badge (with count lower than 100) makes it go up, not aligned with the text like it was before this version. And setting offset doesn't help.

What is expected?

Badge to be aligned to text

What is actually happening?

Badge is offset vertically to the top


You can even see this bug in Badge documentation page, in the "Standalone" section

@zombieJ

This comment has been minimized.

Member

zombieJ commented Sep 26, 2018

@afc163 , could you pls take a look why remove the vertical-align? fd409df#diff-62068314142dce13c064785c1f44b644

@zombieJ zombieJ assigned afc163 and unassigned yutingzhao1991 Sep 26, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Oct 8, 2018

<Badge><span style={{ verticalAlign: 'top' }} /></ Badge>
<Badge><span style={{ verticalAlign: 'top' }} /></ Badge>
<Badge><span style={{ verticalAlign: 'top' }} /></ Badge>

For not changing vertical align of wrapped element.

I should put vertical-align: middle on badge not as a wrapper.

@sbyps

This comment has been minimized.

sbyps commented Oct 22, 2018

badge单独使用加上vertical-align: middle后,在table行中会下对齐,也不太对 @afc163

1 similar comment
@sbyps

This comment has been minimized.

sbyps commented Oct 22, 2018

badge单独使用加上vertical-align: middle后,在table行中会下对齐,也不太对 @afc163

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment