New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress overflow "fix", why? #12718

Closed
Remimstr opened this Issue Oct 18, 2018 · 0 comments

Comments

Projects
None yet
3 participants
@Remimstr

Remimstr commented Oct 18, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.10.1

Environment

Google Chrome

Reproduction link

https://codepen.io/Remimstr/pen/EdLVqb

Steps to reproduce

Use the progress bar with some long text in the format function.

What is expected?

I expect the output of the format function to overflow to the next line if it's too long.

What is actually happening?

The text no longer overflows and simply becomes hidden.


Thank you for this work on this great library, I'm truly appreciative. However, I don't understand why you thought the progress bar overflow was a bug and why you "fixed" it. I think I should be able to decide whether the contents of this component overflow or not. Would you please consider giving me this choice? I think an adequate solution is provide an overflow flag, but a truly excellent one would be to allow the format function to return a React Node. Thank you very kindly.

@afc163 afc163 assigned afc163 and unassigned chenshuai2144 Oct 19, 2018

@afc163 afc163 closed this in f79b099 Oct 19, 2018

ilanus added a commit to ilanus/ant-design that referenced this issue Oct 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment