Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Antd should follow Semantic Versioning 'strictly' #12970

Closed
darylsze opened this issue Nov 6, 2018 · 12 comments
Closed

Antd should follow Semantic Versioning 'strictly' #12970

darylsze opened this issue Nov 6, 2018 · 12 comments
Assignees

Comments

@darylsze
Copy link

@darylsze darylsze commented Nov 6, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

For the changes in 3.7.0, it discards 'filedNames' which causes backward incompatibility, while having breaking changes should pumps one major version following Semantic Versioning standards. Also, in 3.9.0, it discards icon 'cross' without major version upgrade.

What does the proposed API look like?

...

@afc163
Copy link
Member

@afc163 afc163 commented Nov 6, 2018

https://github.com/react-component/cascader/blob/1997960bb37c461895baa88338f73fdf824529da/src/Cascader.jsx#L87-L101

We preserved the typo filedNames usage after 3.7.x and add warning message, so it won't break the original usage and Semantic Versioning too.

@darylsze
Copy link
Author

@darylsze darylsze commented Nov 6, 2018

@afc163 ic. But the icon 'cross' from 3.6.5 is not exist anymore when i upgraded to 3.9.0

@afc163
Copy link
Member

@afc163 afc163 commented Nov 6, 2018

That is our mistake, we will add it back. ant-design/ant-design-icons#26 (comment)

@darylsze
Copy link
Author

@darylsze darylsze commented Nov 6, 2018

Thanks. Its hoping that Antd will follow Semantic Versioning more carefully next time.

@darylsze darylsze closed this Nov 6, 2018
@afc163
Copy link
Member

@afc163 afc163 commented Nov 6, 2018

We will, please give more feedbacks like this so that we can do better.

@darylsze
Copy link
Author

@darylsze darylsze commented Nov 6, 2018

@afc163 yes will do.
Btw, could you provide more known breaking changes made between 3.6.6 and 3.9.0 ? i am investigating the affected area after upgrade, and not sure my mentioned above are the only 2 breaking changes.

@darylsze darylsze reopened this Nov 6, 2018
@afc163
Copy link
Member

@afc163 afc163 commented Nov 6, 2018

We don't know any breaking changes more, we thought it is compatible 100% and maybe something missing now.

afc163 added a commit that referenced this issue Nov 6, 2018
@afc163
Copy link
Member

@afc163 afc163 commented Nov 6, 2018

Just let me know if you find more, I will fix them.

@darylsze
Copy link
Author

@darylsze darylsze commented Nov 6, 2018

thanks!

@darylsze darylsze closed this Nov 6, 2018
@afc163 afc163 reopened this Nov 6, 2018
@afc163
Copy link
Member

@afc163 afc163 commented Nov 6, 2018

filedNames had been broken in antd's code. 😢

0f77949#diff-3141ae7cf791cd0b5edcad2c51dd6dddR130

@afc163 afc163 closed this in e6d9a77 Nov 6, 2018
@afc163
Copy link
Member

@afc163 afc163 commented Nov 6, 2018

The two problems above has been fixed in master, we will release a patch in this weekend. @darylsze

@darylsze
Copy link
Author

@darylsze darylsze commented Nov 6, 2018

afc163 added a commit that referenced this issue Nov 6, 2018
ardok added a commit to ardok/ant-design that referenced this issue Nov 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants