/ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`Button` with `href` prop and `Button` without one appears with a small difference (about 1px) #12978

Closed
serhiiminin opened this Issue Nov 6, 2018 · 1 comment

Comments

Assignees

@afc163 afc163

Labels
Bug🐛
Projects
None yet
Milestone
No milestone
3 participants
@serhiiminin @chenshuai2144 @afc163
@serhiiminin

serhiiminin commented Nov 6, 2018 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.10.0

Environment

Linux, MacOS, Chrome 70.0.3538.77 (Official Build) (64-bit)

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Put Button component with href prop and Button component without href prop close to each other

What is expected?

Buttons are on the same height (without any difference)

What is actually happening?

There is about 1px of difference

on Ubuntu the Button with href prop is 1px lower than without it, but on the MacOS it's vise versa

@ant-design-bot ant-design-bot assigned chenshuai2144 Nov 6, 2018

@afc163 afc163 assigned afc163 and unassigned chenshuai2144 Nov 6, 2018

@afc163 afc163 added the Bug🐛 label Nov 6, 2018

@afc163 afc163 closed this in adee2f3 Nov 6, 2018

@serhiiminin

This comment has been minimized.

Sign in to view

serhiiminin commented Nov 6, 2018 •
edited

Cool! Without any comment! Just closed an issue. Very nice!

@afc163 afc163 reopened this Nov 11, 2018

@afc163 afc163 closed this in 664089e Nov 11, 2018

afc163 added a commit that referenced this issue Nov 11, 2018

@afc163
🐛 Fix typo, #12978
Verified
This commit was signed with a verified signature.
@afc163 afc163 偏右
GPG key ID: 5F00908D72002306 Learn about signing commits
Loading status checks…
74aeace

afc163 added a commit that referenced this issue Nov 12, 2018

@afc163
Merge branch 'master' into feature 
* master:
  🔥 update less code style
  ⬆️ upgrade react-dnd version
  update
  Remove unused dependencies
  3.10.7 changelog
  🐛 Fix typo, #12978
  update changelog
  ✨ Release 3.10.6
  🚑 Fix Button[href] 1px align bug in another way
  tweak style
  💄 tweak button style
Loading status checks…
cdafee7

@ztplz ztplz referenced this issue Nov 27, 2018

Open

The marginTop of the antd components are different. #13214

0 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment