Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button with href prop and Button without one appears with a small difference (about 1px) #12978

Closed
serhiiminin opened this issue Nov 6, 2018 · 1 comment
Assignees
Labels

Comments

@serhiiminin
Copy link

@serhiiminin serhiiminin commented Nov 6, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.10.0

Environment

Linux, MacOS, Chrome 70.0.3538.77 (Official Build) (64-bit)

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Put Button component with href prop and Button component without href prop close to each other

What is expected?

Buttons are on the same height (without any difference)

What is actually happening?

There is about 1px of difference


on Ubuntu the Button with href prop is 1px lower than without it, but on the MacOS it's vise versa

@serhiiminin
Copy link
Author

@serhiiminin serhiiminin commented Nov 6, 2018

Cool! Without any comment! Just closed an issue. Very nice!

@afc163 afc163 reopened this Nov 11, 2018
@afc163 afc163 closed this in 664089e Nov 11, 2018
afc163 added a commit that referenced this issue Nov 11, 2018
afc163 added a commit that referenced this issue Nov 12, 2018
* master:
  🔥 update less code style
  ⬆️ upgrade react-dnd version
  update
  Remove unused dependencies
  3.10.7 changelog
  🐛 Fix typo, #12978
  update changelog
   Release 3.10.6
  🚑 Fix Button[href] 1px align bug in another way
  tweak style
  💄 tweak button style
@ztplz ztplz mentioned this issue Jan 13, 2019
0 of 1 task complete
afc163 added a commit that referenced this issue Aug 7, 2019
close #18107
close #13214 too

caused by the fix of #12978

changing another way to fix #12978
@afc163 afc163 mentioned this issue Aug 7, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

3 participants