Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃巹 Christmas easter egg 馃巹 #13098

Closed
1 task done
davidebianchi opened this issue Nov 12, 2018 · 187 comments
Closed
1 task done

馃巹 Christmas easter egg 馃巹 #13098

davidebianchi opened this issue Nov 12, 2018 · 187 comments

Comments

@davidebianchi
Copy link
Contributor

@davidebianchi davidebianchi commented Nov 12, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Christmas easter egg is a really fun joke, but in business app we should give the possibilities to switch off that. This feature could block users from using this awesome library

What does the proposed API look like?

My proposal is a prop (also true by default) and when switched to false it block the easter egg.

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 23, 2018

You can override the css : )

.ant-btn.ant-btn-primary.christmas:before {
  display: none!important;
}

@zombieJ zombieJ closed this Nov 23, 2018
@LyricL-Gitster
Copy link

@LyricL-Gitster LyricL-Gitster commented Dec 18, 2018

This might be ok for such a widely used application if it was at least opt-in... I cannot use this library professionally with this applied, and it is unfortunate that I had to scour source code to find it...

@caitecoll
Copy link

@caitecoll caitecoll commented Dec 18, 2018

Are there any other Easter eggs like this within Ant? I want to be sure I'm overriding them in my application.

@schnerd
Copy link

@schnerd schnerd commented Dec 22, 2018

I really want to use Ant for future projects but decisions like this concern me. I imagine some poor developers are going to have their Christmas day interrupted when they get an angry email from their managers asking to remove the snow from all the buttons.

@zenoven
Copy link

@zenoven zenoven commented Dec 24, 2018

it's not fun at all...

at least there should be some config to disable it, not override the style!!!

@afc163 afc163 reopened this Dec 24, 2018
@afc163 afc163 pinned this issue Dec 24, 2018
@afc163 afc163 changed the title Christmas easter egg 馃巹 Christmas easter egg 馃巹 Dec 24, 2018
@afc163
Copy link
Member

@afc163 afc163 commented Dec 24, 2018

We will make 00aebeb optinal in next patch version, there is a potential ConfigProvider API without any date judgement condition, and the default value of snowyButton would be false.

<ConfigProvider snowyButton={true}>
  ...
</ConfigProvider>

Also, Merry Christmas to everybody~ 馃ざ馃徎


Removed the egg in antd@3.11.6 now.

afc163 referenced this issue Dec 24, 2018
@aliustaoglu
Copy link

@aliustaoglu aliustaoglu commented Dec 24, 2018

I would not recommend overriding CSS. All buttons come with "Ho ho ho!" title. If you remove the snow, title will pop up when you hover on the button. And it cannot be removed with CSS. You'll need to edit DOM. At least with the snow it will be more obvious that it's an easter egg and more acceptable for users than a normal button with "Ho ho ho!" title.

@jasper-wan
Copy link

@jasper-wan jasper-wan commented Dec 25, 2018

Easter egg should be disabled by default in production mode.

@ybning
Copy link

@ybning ybning commented Dec 25, 2018

鎬庝箞鍘绘帀

title="Ho Ho Ho!"

?
@zombieJ
@afc163

@theMxb
Copy link

@theMxb theMxb commented Dec 25, 2018

鎬庝箞鍘婚櫎

@georgehpj
Copy link

@georgehpj georgehpj commented Dec 25, 2018

鎴戜滑鏄仛2B搴旂敤鐨勶紝杩欑鈥滃僵铔嬧濊浜烘湁澶辨帶鐨勬劅瑙夈傜炕浜嗕笅杩囧幓鐨剅elease閲屼篃娌℃湁鎻愬埌杩囪繖涓僵铔嬶紝鐪嬭捣鏉ユ槸鏁呮剰涓轰箣銆備絾鐢ㄦ埛濡傛灉鏈夋剰瑙侊紝鎴戜滑灏辫鍔ㄤ簡銆傚姞褰╄泲鍙互锛屼絾鏈濂芥帶鍒舵潈杩樻槸鍦ㄥ紑鍙戣呮墜閲岋紝榛樿鍏抽棴锛岀敱寮鍙戣呭喅瀹氭槸鍚﹀紑鍚傚紑鍙戣呯粰鏈缁堜娇鐢ㄨ呯殑鎯婂枩鍙滃僵铔嬧濓紝妗嗘灦缁欏紑鍙戣呯殑鎯婂枩灏辨槸鎯婂悡浜嗏︹

@onfuns
Copy link

@onfuns onfuns commented Dec 25, 2018

So foolish锛侊紒锛

@chaegumi
Copy link

@chaegumi chaegumi commented Dec 25, 2018

馃挃

@hengkx
Copy link
Member

@hengkx hengkx commented Dec 25, 2018

鍚撴垜涓璺筹紝娌℃湁 浠讳綍 璇存槑 绐佺劧 鏉ヨ繖涔堜竴涓

@weig
Copy link

@weig weig commented Dec 25, 2018

This is ridiculous! We are running serious business using Ant.Design.

If Ant.Design is designed as "library", how and when to present an Easter egg should be controlled by the application developer, not the library.

Christmas is a happy day, but not for every business.

@zhaoy0221
Copy link

@zhaoy0221 zhaoy0221 commented Dec 25, 2018

鍚撴瀹濆疂浜嗭紒

@Airkro
Copy link
Contributor

@Airkro Airkro commented Dec 25, 2018

鎵璋撯滃僵铔嬧濆氨鏄笉浼氫簨鍏堥氱煡鐨勩

鎴戣寰楅洩鑺卞鏋滀娇鐢ㄨ兘澶熶娇鐢ㄦ洿楂樿瀺鍚堝害鐨勮璁★紝涔熻鏇村浜鸿兘涓绗戠疆涔嬶紝姣曠珶娌℃湁浠涔堜笉鑹奖鍝嶃傛垨璁歌繕鑳借幏寰楀ソ璇勶紝姣曠珶skin杩欎釜姒傚康鏄湁鐨勩傚彲鎯滅幇鍦ㄦ墎骞崇殑鐣岄潰閲岄偅鍧3D闆傘傘
浣嗘槸鏀瑰啓 title 瀹屽叏娌″繀瑕侊紝浠夸經鍍忔槸鎭朵綔鍓т簡銆

@bao-han
Copy link

@bao-han bao-han commented Dec 25, 2018

鍓嶆帓鍥磋

@Airkro
Copy link
Contributor

@Airkro Airkro commented Dec 25, 2018

澶у鍙互鐩存帴鍥炴粴鍒 3.9.2 涔嬪墠銆傘傘
鍙﹀娌℃湁寤鸿鍨嬬殑鑱婂ぉ鐪熺殑搴旇鍋滄锛岃鍏ㄧ悆璺熺潃鐪嬬瑧璇濇病蹇呰锛岃繕鏆撮湶鑷繁鐨勬按鍑嗐

@afc163
<ConfigProvider snowyButton={true}> 鎴戣涓烘病蹇呰瀹炵幇锛屾瘯绔熶笉鍒14涓皬鏃惰妭鏃ュ氨杩囦簡銆傛病蹇呰鍗犵敤浠g爜閲忓拰娴侀噺銆

@WWR1234567
Copy link

@WWR1234567 WWR1234567 commented Dec 25, 2018

鍧愮瓑濂芥垙

@vipbo
Copy link

@vipbo vipbo commented Dec 25, 2018

涓嶆暍鎯宠薄4.1鏃ヤ細鍑虹幇浠涔堬紒

@WadeZhu
Copy link

@WadeZhu WadeZhu commented Dec 25, 2018

鏄ヨ妭浼氫笉浼氭潵涓查灜鐐

@DA-GAMER
Copy link

@DA-GAMER DA-GAMER commented Dec 25, 2018

image
杩樻湁銆傘備綘浠殑瀹樼綉棣栭〉Christmas濂藉儚鎷奸敊浜嗗惂銆傘

婊戝ぉ涓嬩箣澶хń

@zibuyu69
Copy link

@zibuyu69 zibuyu69 commented Dec 25, 2018

鎴戣繕瑙夊緱鎸哄彲鐖甭仿仿仿风珶鐒跺ぇ澶氭暟浜轰笉鍠滄 路銆偮风湅鏉ヨ繖绉嶈妯$殑搴撹繕鏄棣栧厛鑰冭檻鐢ㄦ埛鐨勪笅闄愶紝鐒跺悗鍐嶉敠涓婃坊鑺

@timothynode
Copy link

@timothynode timothynode commented Dec 25, 2018

鏉ョ灖涓鐬х湅涓鐪嬩簡~~~娆㈣繋鍚勪綅鏈夊墠绔妧鏈儹鎯呯殑鍚屽鍔犲叆鎴戜滑銆傜壒鍒湴锛屾垜浠笉浼氬洜涓轰竴涓僵铔嬪氨鏉浜嗙▼搴忓憳绁ぉ銆傘傘俠ase 骞垮窞锛屼笂甯傚叕鍙搞傚箍鎷涘墠绔悗鍙皛~~鏈夊叴瓒i偖浠朵竴涓嬬畝鍘嗚阿璋~~

@freedom520
Copy link

@freedom520 freedom520 commented Dec 25, 2018

鐪嬪埌澶у閮藉湪鍠凤紝鎴戝氨鏀惧績浜嗐傚彟澶栨澀宸炴捣鍒涘洯鎷涘墠绔珮绾у紑鍙戯紒

杩欐尝鎷涜仒鍘夊浜

@vipbo
Copy link

@vipbo vipbo commented Dec 25, 2018

涓嶆暍鎯宠薄4.1鏃ヤ細鍑虹幇浠涔堬紒

@pangjunpeng
Copy link

@pangjunpeng pangjunpeng commented Dec 25, 2018

image
杩樻湁銆傘備綘浠殑瀹樼綉棣栭〉Christmas濂藉儚鎷奸敊浜嗗惂銆傘

鎶婃垜鐨勪節灞傚濉旀嬁鍑烘潵锛屾垜瑕佺粰绉鍎胯捀绗煎寘瀛

@Alice-gxh
Copy link

@Alice-gxh Alice-gxh commented Dec 25, 2018

Merry Christmas锛
鍦h癁蹇箰(^鈻絕)
鎴戞潵鍐欎釜姝g‘鐨勫惂锛乛_^

@Dante-dan
Copy link

@Dante-dan Dante-dan commented Dec 25, 2018

鏉ョ灖涓鐬х湅涓鐪嬩簡~~~娆㈣繋鍚勪綅鏈夊墠绔妧鏈儹鎯呯殑鍚屽鍔犲叆鎴戜滑銆傜壒鍒湴锛屾垜浠笉浼氬洜涓轰竴涓僵铔嬪氨鏉浜嗙▼搴忓憳绁ぉ銆傘傘俠ase 骞垮窞锛屼笂甯傚叕鍙搞傚箍鎷涘墠绔悗鍙皛~~鏈夊叴瓒i偖浠朵竴涓嬬畝鍘嗚阿璋~~

浼樼鍟

@narco001
Copy link

@narco001 narco001 commented Dec 25, 2018

澶х増鏈4.x.x鍗囩骇涓嶄細缁欐垜浠竴涓緢澶у緢澶х殑鎯婂枩鍚э紒锛侊紒锛侊紒锛燂紵锛燂紵锛

@yuu2lee4
Copy link

@yuu2lee4 yuu2lee4 commented Dec 25, 2018

杩欑褰╄泲鍒板簳鏄缁欏鎴峰甫鏉"鎯婂枩"锛岃繕鏄粰寮鍙戣呭甫鏉ユ儕鍚擄紵

@Kaier33
Copy link

@Kaier33 Kaier33 commented Dec 25, 2018

img

@Dante-dan
Copy link

@Dante-dan Dante-dan commented Dec 25, 2018

寮勪釜鎶曠エ锛屾垜鎶曡禐鎴愮エ锛

@annyHu
Copy link

@annyHu annyHu commented Dec 25, 2018

鍧愮瓑鍚冪摐

@kalsolio
Copy link

@kalsolio kalsolio commented Dec 25, 2018

鐪熸槸娌′竴鐐硅矗浠诲績 涓嶈冭檻鐢ㄦ埛浣跨敤鍦烘櫙

@luliangce
Copy link

@luliangce luliangce commented Dec 25, 2018

浼婃柉鍏板浗瀹惰繃鍦h癁鑺傚悧?鎵撳紑涓鐪嬪崄瀛楀啗鍗犻鑷繁瀹剁綉绔欎簡?鍓嶇琚爫姝绘湁浜鸿礋璐e悧?

@tao1991123
Copy link

@tao1991123 tao1991123 commented Dec 25, 2018

渚电姱鎴戜滑鏃犵璁鸿呯殑淇′话鑷敱

@stbui
Copy link

@stbui stbui commented Dec 25, 2018

杩欎唬鐮佹庝箞鍔犱笂鍘荤殑锛

@lu-lu-wang
Copy link

@lu-lu-wang lu-lu-wang commented Dec 25, 2018

杩欐尝鎿嶄綔寰堟簻锛岃繕濂芥垜浠嚎涓婄増鏈病鏇存柊锛屽按灏馃槗

@RoJoHub
Copy link

@RoJoHub RoJoHub commented Dec 25, 2018

What about the Spring Festival? Nothing in the Spring Festival?
Ant???
Only Christmas?


鏄ヨ妭鍛?鏄ヨ妭娌℃湁鍢???
Ant???
鍙湁鍦h癁?

@orzyyyy
Copy link
Contributor

@orzyyyy orzyyyy commented Dec 25, 2018

Issue 鏄敤鏉ユ彁闂璺熻В鍐抽棶棰橈紝鑰屼笉鏄敤鏉ョ倰鐑偣鐨勶紝璁ㄨ鍒拌繖浠戒笂鍙兘閿佷簡

Issue is used to raise and solve problems, not to stir up hot spots, I lock this.

@orzyyyy orzyyyy closed this Dec 25, 2018
@ant-design ant-design locked as too heated and limited conversation to collaborators Dec 25, 2018
@xiaohuoni xiaohuoni unpinned this issue Dec 25, 2018
@afc163 afc163 pinned this issue Dec 25, 2018
@afc163 afc163 unpinned this issue Dec 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet