New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎄 Christmas easter egg 🎄 #13098

Closed
davidebianchi opened this Issue Nov 12, 2018 · 187 comments

Comments

Projects
None yet
@davidebianchi
Copy link

davidebianchi commented Nov 12, 2018

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Christmas easter egg is a really fun joke, but in business app we should give the possibilities to switch off that. This feature could block users from using this awesome library

What does the proposed API look like?

My proposal is a prop (also true by default) and when switched to false it block the easter egg.

@zombieJ

This comment has been minimized.

Copy link
Member

zombieJ commented Nov 23, 2018

You can override the css : )

.ant-btn.ant-btn-primary.christmas:before {
  display: none!important;
}

@zombieJ zombieJ closed this Nov 23, 2018

@llhupp

This comment has been minimized.

Copy link

llhupp commented Dec 18, 2018

This might be ok for such a widely used application if it was at least opt-in... I cannot use this library professionally with this applied, and it is unfortunate that I had to scour source code to find it...

@caitecoll

This comment has been minimized.

Copy link

caitecoll commented Dec 18, 2018

Are there any other Easter eggs like this within Ant? I want to be sure I'm overriding them in my application.

@schnerd

This comment has been minimized.

Copy link

schnerd commented Dec 22, 2018

I really want to use Ant for future projects but decisions like this concern me. I imagine some poor developers are going to have their Christmas day interrupted when they get an angry email from their managers asking to remove the snow from all the buttons.

@zenoven

This comment has been minimized.

Copy link

zenoven commented Dec 24, 2018

it's not fun at all...

at least there should be some config to disable it, not override the style!!!

@afc163 afc163 reopened this Dec 24, 2018

@afc163 afc163 pinned this issue Dec 24, 2018

@afc163 afc163 changed the title Christmas easter egg 🎄 Christmas easter egg 🎄 Dec 24, 2018

@afc163

This comment has been minimized.

Copy link
Member

afc163 commented Dec 24, 2018

We will make 00aebeb optinal in next patch version, there is a potential ConfigProvider API without any date judgement condition, and the default value of snowyButton would be false.

<ConfigProvider snowyButton={true}>
  ...
</ConfigProvider>

Also, Merry Christmas to everybody~ 🤶🏻


Removed the egg in antd@3.11.6 now.

afc163 referenced this issue Dec 24, 2018

@aliustaoglu

This comment has been minimized.

Copy link

aliustaoglu commented Dec 24, 2018

I would not recommend overriding CSS. All buttons come with "Ho ho ho!" title. If you remove the snow, title will pop up when you hover on the button. And it cannot be removed with CSS. You'll need to edit DOM. At least with the snow it will be more obvious that it's an easter egg and more acceptable for users than a normal button with "Ho ho ho!" title.

@Jasper0819X

This comment has been minimized.

Copy link

Jasper0819X commented Dec 25, 2018

Easter egg should be disabled by default in production mode.

@ybning

This comment has been minimized.

Copy link

ybning commented Dec 25, 2018

怎么去掉

title="Ho Ho Ho!"

?
@zombieJ
@afc163

@theMxb

This comment has been minimized.

Copy link

theMxb commented Dec 25, 2018

怎么去除

@georgehpj

This comment has been minimized.

Copy link

georgehpj commented Dec 25, 2018

我们是做2B应用的,这种“彩蛋”让人有失控的感觉。翻了下过去的release里也没有提到过这个彩蛋,看起来是故意为之。但用户如果有意见,我们就被动了。加彩蛋可以,但最好控制权还是在开发者手里,默认关闭,由开发者决定是否开启。开发者给最终使用者的惊喜叫“彩蛋”,框架给开发者的惊喜就是惊吓了……

@onfuns

This comment has been minimized.

Copy link

onfuns commented Dec 25, 2018

So foolish!!!

@chaegumi

This comment has been minimized.

Copy link

chaegumi commented Dec 25, 2018

💔

@hengkx

This comment has been minimized.

Copy link
Contributor

hengkx commented Dec 25, 2018

吓我一跳,没有 任何 说明 突然 来这么一下

@weig

This comment has been minimized.

Copy link

weig commented Dec 25, 2018

This is ridiculous! We are running serious business using Ant.Design.

If Ant.Design is designed as "library", how and when to present an Easter egg should be controlled by the application developer, not the library.

Christmas is a happy day, but not for every business.

@TnWah

This comment has been minimized.

Copy link

TnWah commented Dec 25, 2018

吓死宝宝了!

@Airkro

This comment has been minimized.

Copy link

Airkro commented Dec 25, 2018

所谓“彩蛋”就是不会事先通知的。

我觉得雪花如果使用能够使用更高融合度的设计,也许更多人能一笑置之,毕竟没有什么不良影响。或许还能获得好评,毕竟skin这个概念是有的。可惜现在扁平的界面里那块3D雪。。。
但是改写 title 完全没必要,仿佛像是恶作剧了。

@bao-han

This comment has been minimized.

Copy link

bao-han commented Dec 25, 2018

前排围观

@Airkro

This comment has been minimized.

Copy link

Airkro commented Dec 25, 2018

大家可以直接回滚到 3.9.2 之前。。。
另外没有建设型的聊天真的应该停止,让全球跟着看笑话没必要,还暴露自己的水准。

@afc163
<ConfigProvider snowyButton={true}> 我认为没必要实现,毕竟不到14个小时节日就过了。没必要占用代码量和流量。

@WWR1234567

This comment has been minimized.

Copy link

WWR1234567 commented Dec 25, 2018

坐等好戏

@vipbo

This comment has been minimized.

Copy link

vipbo commented Dec 25, 2018

不敢想象4.1日会出现什么!

@WadeZhu

This comment has been minimized.

Copy link

WadeZhu commented Dec 25, 2018

春节会不会来串鞭炮

@MokerT

This comment has been minimized.

Copy link

MokerT commented Dec 25, 2018

image
还有。。你们的官网首页Christmas好像拼错了吧。。

滑天下之大稽

@zibuyu69

This comment has been minimized.

Copy link

zibuyu69 commented Dec 25, 2018

我还觉得挺可爱····竟然大多数人不喜欢 ·。·看来这种规模的库还是要首先考虑用户的下限,然后再锦上添花

@timothynode

This comment has been minimized.

Copy link

timothynode commented Dec 25, 2018

来瞧一瞧看一看了~~~欢迎各位有前端技术热情的同学加入我们。特别地,我们不会因为一个彩蛋就杀了程序员祭天。。。base 广州,上市公司。广招前端后台~~~有兴趣邮件一下简历谢谢~~~

@freedom520

This comment has been minimized.

Copy link

freedom520 commented Dec 25, 2018

看到大家都在喷,我就放心了。另外杭州海创园招前端高级开发!

这波招聘厉害了

@vipbo

This comment has been minimized.

Copy link

vipbo commented Dec 25, 2018

不敢想象4.1日会出现什么!

@pangjunpeng

This comment has been minimized.

Copy link

pangjunpeng commented Dec 25, 2018

image
还有。。你们的官网首页Christmas好像拼错了吧。。

把我的九层妖塔拿出来,我要给秀儿蒸笼包子

@Alice-gxh

This comment has been minimized.

Copy link

Alice-gxh commented Dec 25, 2018

Merry Christmas!
圣诞快乐(^▽^)
我来写个正确的吧!^_^

@Dante-dan

This comment has been minimized.

Copy link

Dante-dan commented Dec 25, 2018

来瞧一瞧看一看了~~~欢迎各位有前端技术热情的同学加入我们。特别地,我们不会因为一个彩蛋就杀了程序员祭天。。。base 广州,上市公司。广招前端后台~~~有兴趣邮件一下简历谢谢~~~

优秀啊

@narco001

This comment has been minimized.

Copy link

narco001 commented Dec 25, 2018

大版本4.x.x升级不会给我们一个很大很大的惊喜吧!!!!!?????

@yuu2lee4

This comment has been minimized.

Copy link

yuu2lee4 commented Dec 25, 2018

这种彩蛋到底是要给客户带来"惊喜",还是给开发者带来惊吓?

@KaierChou

This comment has been minimized.

Copy link

KaierChou commented Dec 25, 2018

img

@Dante-dan

This comment has been minimized.

Copy link

Dante-dan commented Dec 25, 2018

弄个投票,我投赞成票!

@annyHu

This comment has been minimized.

Copy link

annyHu commented Dec 25, 2018

坐等吃瓜

@kalsolio

This comment has been minimized.

Copy link

kalsolio commented Dec 25, 2018

真是没一点责任心 不考虑用户使用场景

@luliangce

This comment has been minimized.

Copy link

luliangce commented Dec 25, 2018

伊斯兰国家过圣诞节吗?打开一看十字军占领自己家网站了?前端被砍死有人负责吗?

@tao1991123

This comment has been minimized.

Copy link

tao1991123 commented Dec 25, 2018

侵犯我们无神论者的信仰自由

@stbui

This comment has been minimized.

Copy link

stbui commented Dec 25, 2018

这代码怎么加上去的?

@lu-lu-wang

This comment has been minimized.

Copy link

lu-lu-wang commented Dec 25, 2018

这波操作很溜,还好我们线上版本没更新,尴尬😓

@RoJoHub

This comment has been minimized.

Copy link

RoJoHub commented Dec 25, 2018

What about the Spring Festival? Nothing in the Spring Festival?
Ant???
Only Christmas?


春节呢?春节没有嘛???
Ant???
只有圣诞?

@zy410419243

This comment has been minimized.

Copy link
Contributor

zy410419243 commented Dec 25, 2018

Issue 是用来提问题跟解决问题,而不是用来炒热点的,讨论到这份上只能锁了

Issue is used to raise and solve problems, not to stir up hot spots, I lock this.

@ant-design ant-design locked as too heated and limited conversation to collaborators Dec 25, 2018

@xiaohuoni xiaohuoni unpinned this issue Dec 25, 2018

@afc163 afc163 pinned this issue Dec 25, 2018

@afc163 afc163 unpinned this issue Dec 25, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.