Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up🎄 Christmas easter egg 🎄 #13098
Comments
ant-design-bot
assigned
afc163
Nov 12, 2018
This comment has been minimized.
This comment has been minimized.
|
You can override the css : ) .ant-btn.ant-btn-primary.christmas:before {
display: none!important;
} |
zombieJ
closed this
Nov 23, 2018
This comment has been minimized.
This comment has been minimized.
llhupp
commented
Dec 18, 2018
•
|
This might be ok for such a widely used application if it was at least opt-in... I cannot use this library professionally with this applied, and it is unfortunate that I had to scour source code to find it... |
This comment has been minimized.
This comment has been minimized.
caitecoll
commented
Dec 18, 2018
|
Are there any other Easter eggs like this within Ant? I want to be sure I'm overriding them in my application. |
This comment has been minimized.
This comment has been minimized.
schnerd
commented
Dec 22, 2018
•
|
I really want to use Ant for future projects but decisions like this concern me. I imagine some poor developers are going to have their Christmas day interrupted when they get an angry email from their managers asking to remove the snow from all the buttons. |
afc163
referenced this issue
Dec 24, 2018
Closed
Please remove Christmas Easter Egg for Ant Design framework #13818
This comment has been minimized.
This comment has been minimized.
zenoven
commented
Dec 24, 2018
|
it's not fun at all... at least there should be some config to disable it, not override the style!!! |
afc163
reopened this
Dec 24, 2018
afc163
added
Discussion
Accept
help wanted
labels
Dec 24, 2018
afc163
pinned this issue
Dec 24, 2018
afc163
changed the title
Christmas easter egg
🎄 Christmas easter egg 🎄
Dec 24, 2018
This comment has been minimized.
This comment has been minimized.
|
<ConfigProvider snowyButton={true}>
...
</ConfigProvider>Also, Merry Christmas to everybody~ 🤶🏻 Removed the egg in |
referenced
this issue
Dec 24, 2018
afc163
added
the
IssueHuntFest
label
Dec 24, 2018
This comment has been minimized.
This comment has been minimized.
aliustaoglu
commented
Dec 24, 2018
|
I would not recommend overriding CSS. All buttons come with "Ho ho ho!" title. If you remove the snow, title will pop up when you hover on the button. And it cannot be removed with CSS. You'll need to edit DOM. At least with the snow it will be more obvious that it's an easter egg and more acceptable for users than a normal button with "Ho ho ho!" title. |
This comment has been minimized.
This comment has been minimized.
Jasper0819X
commented
Dec 25, 2018
|
Easter egg should be disabled by default in production mode. |
This comment has been minimized.
This comment has been minimized.
ybning
commented
Dec 25, 2018
•
This comment has been minimized.
This comment has been minimized.
theMxb
commented
Dec 25, 2018
|
怎么去除 |
This comment has been minimized.
This comment has been minimized.
georgehpj
commented
Dec 25, 2018
|
我们是做2B应用的,这种“彩蛋”让人有失控的感觉。翻了下过去的release里也没有提到过这个彩蛋,看起来是故意为之。但用户如果有意见,我们就被动了。加彩蛋可以,但最好控制权还是在开发者手里,默认关闭,由开发者决定是否开启。开发者给最终使用者的惊喜叫“彩蛋”,框架给开发者的惊喜就是惊吓了…… |
This comment has been minimized.
This comment has been minimized.
onfuns
commented
Dec 25, 2018
|
So foolish!!! |
This comment has been minimized.
This comment has been minimized.
chaegumi
commented
Dec 25, 2018
|
|
This comment has been minimized.
This comment has been minimized.
|
吓我一跳,没有 任何 说明 突然 来这么一下 |
This comment has been minimized.
This comment has been minimized.
weig
commented
Dec 25, 2018
|
This is ridiculous! We are running serious business using Ant.Design. If Ant.Design is designed as "library", how and when to present an Easter egg should be controlled by the application developer, not the library. Christmas is a happy day, but not for every business. |
This comment has been minimized.
This comment has been minimized.
TnWah
commented
Dec 25, 2018
|
吓死宝宝了! |
This comment has been minimized.
This comment has been minimized.
Airkro
commented
Dec 25, 2018
|
所谓“彩蛋”就是不会事先通知的。 我觉得雪花如果使用能够使用更高融合度的设计,也许更多人能一笑置之,毕竟没有什么不良影响。或许还能获得好评,毕竟skin这个概念是有的。可惜现在扁平的界面里那块3D雪。。。 |
This comment has been minimized.
This comment has been minimized.
bao-han
commented
Dec 25, 2018
|
前排围观 |
This comment has been minimized.
This comment has been minimized.
Airkro
commented
Dec 25, 2018
|
大家可以直接回滚到 3.9.2 之前。。。 @afc163 |
This comment has been minimized.
This comment has been minimized.
WWR1234567
commented
Dec 25, 2018
|
坐等好戏 |
This comment has been minimized.
This comment has been minimized.
vipbo
commented
Dec 25, 2018
|
不敢想象4.1日会出现什么! |
This comment has been minimized.
This comment has been minimized.
WadeZhu
commented
Dec 25, 2018
|
春节会不会来串鞭炮 |
This comment has been minimized.
This comment has been minimized.
MokerT
commented
Dec 25, 2018
This comment has been minimized.
This comment has been minimized.
zibuyu69
commented
Dec 25, 2018
|
我还觉得挺可爱····竟然大多数人不喜欢 ·。·看来这种规模的库还是要首先考虑用户的下限,然后再锦上添花 |
This comment has been minimized.
This comment has been minimized.
timothynode
commented
Dec 25, 2018
|
来瞧一瞧看一看了~~~欢迎各位有前端技术热情的同学加入我们。特别地,我们不会因为一个彩蛋就杀了程序员祭天。。。base 广州,上市公司。广招前端后台~~~有兴趣邮件一下简历谢谢~~~ |
This comment has been minimized.
This comment has been minimized.
freedom520
commented
Dec 25, 2018
这波招聘厉害了 |
This comment has been minimized.
This comment has been minimized.
vipbo
commented
Dec 25, 2018
|
不敢想象4.1日会出现什么! |
This comment has been minimized.
This comment has been minimized.
pangjunpeng
commented
Dec 25, 2018
This comment has been minimized.
This comment has been minimized.
Alice-gxh
commented
Dec 25, 2018
|
Merry Christmas! |
This comment has been minimized.
This comment has been minimized.
Dante-dan
commented
Dec 25, 2018
优秀啊 |
This comment has been minimized.
This comment has been minimized.
narco001
commented
Dec 25, 2018
|
大版本4.x.x升级不会给我们一个很大很大的惊喜吧!!!!!????? |
This comment has been minimized.
This comment has been minimized.
yuu2lee4
commented
Dec 25, 2018
|
这种彩蛋到底是要给客户带来"惊喜",还是给开发者带来惊吓? |
This comment has been minimized.
This comment has been minimized.
KaierChou
commented
Dec 25, 2018
This comment has been minimized.
This comment has been minimized.
Dante-dan
commented
Dec 25, 2018
|
弄个投票,我投赞成票! |
This comment has been minimized.
This comment has been minimized.
annyHu
commented
Dec 25, 2018
|
坐等吃瓜 |
This comment has been minimized.
This comment has been minimized.
kalsolio
commented
Dec 25, 2018
|
真是没一点责任心 不考虑用户使用场景 |
This comment has been minimized.
This comment has been minimized.
luliangce
commented
Dec 25, 2018
|
伊斯兰国家过圣诞节吗?打开一看十字军占领自己家网站了?前端被砍死有人负责吗? |
This comment has been minimized.
This comment has been minimized.
tao1991123
commented
Dec 25, 2018
|
侵犯我们无神论者的信仰自由 |
This comment has been minimized.
This comment has been minimized.
stbui
commented
Dec 25, 2018
|
这代码怎么加上去的? |
This comment has been minimized.
This comment has been minimized.
lu-lu-wang
commented
Dec 25, 2018
|
这波操作很溜,还好我们线上版本没更新,尴尬 |
This comment has been minimized.
This comment has been minimized.
RoJoHub
commented
Dec 25, 2018
|
What about the Spring Festival? Nothing in the Spring Festival? 春节呢?春节没有嘛??? |
This comment has been minimized.
This comment has been minimized.
|
Issue 是用来提问题跟解决问题,而不是用来炒热点的,讨论到这份上只能锁了 Issue is used to raise and solve problems, not to stir up hot spots, I lock this. |


davidebianchi commentedNov 12, 2018
•
edited
What problem does this feature solve?
Christmas easter egg is a really fun joke, but in business app we should give the possibilities to switch off that. This feature could block users from using this awesome library
What does the proposed API look like?
My proposal is a prop (also true by default) and when switched to false it block the easter egg.