Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃巺 About the Christmas egg and workaround #13849

Closed
afc163 opened this issue Dec 25, 2018 · 63 comments
Closed

馃巺 About the Christmas egg and workaround #13849

afc163 opened this issue Dec 25, 2018 · 63 comments

Comments

@afc163
Copy link
Member

@afc163 afc163 commented Dec 25, 2018

About the christmas egg in antd, it is derived from my commit 00aebeb at Sep 10th. This implementation will make primary button snowy with native tooltip Ho Ho Ho! at the specificed day of Dec 25th. It is a complete stupid decision of my own and very sorry to everyone that get involved.

How it

Versions would be affected: 3.9.33.10.0 ~ 3.10.93.11.0 ~ 3.11.5

We reverted the related commit and release patches: 3.9.4 3.10.10 3.11.6 you can upgrade to. If you are using semver version, reinstall node_modules would be ok.

Are there other eggs in antd's code.

No.

Are there same events would happen in future?

No, I promise. We are open source project, please supervise us like this time, like always.

@afc163 afc163 pinned this issue Dec 25, 2018
@alwaysloseall
Copy link
Contributor

@alwaysloseall alwaysloseall commented Dec 25, 2018

Be careful next time.bro

@zephyrleaves
Copy link

@zephyrleaves zephyrleaves commented Dec 25, 2018

pity boy

"projest" is project , be relax

@LeeYunhang
Copy link

@LeeYunhang LeeYunhang commented Dec 25, 2018

AntDesign should not add feature to original components without developer's agree not only Christmas egg. :(

@xiaoxiaoting
Copy link

@xiaoxiaoting xiaoxiaoting commented Dec 25, 2018

pity boy

"projest" is project , be relax

鍝堝搱鍝堝搱鍝堝搱

@afc163 afc163 changed the title About the Chrismas egg and workaround 馃巺 About the Chrismas egg and workaround Dec 25, 2018
@CupNoodleFork
Copy link

@CupNoodleFork CupNoodleFork commented Dec 25, 2018

鑰佸摜浣 christmas 杩樻槸鎷奸敊浜嗐

@dengkunli
Copy link

@dengkunli dengkunli commented Dec 25, 2018

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

@Riadloc
Copy link

@Riadloc Riadloc commented Dec 25, 2018

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

Are you 绉鍎?

@Ragzzy-R
Copy link

@Ragzzy-R Ragzzy-R commented Dec 25, 2018

our UAT push yesterday got postponed because of this as our client is not a christmas-ish person and we dont want to piss him off. Antd is supposed to be an enterprise UI solution please prevent such things in future or atleast give a headsup. Although! we love u guys! and all the time you help us save. so cheers! and Merry Christmas 馃憤

@lloydsheng
Copy link

@lloydsheng lloydsheng commented Dec 25, 2018

浣滆呭お绱у紶浜嗭紝鍐欎簡寰堝璇硶閿欒銆傚ぇ瀹惰繕鏄墜涓嬬暀鎯咃紝鍏堟妸闂瑙e喅鎺 馃槀

@gztchan
Copy link

@gztchan gztchan commented Dec 25, 2018

Merry Christmas 馃巺馃徎Just upgrade the library and let it go, guys!

@zclaiqcc
Copy link

@zclaiqcc zclaiqcc commented Dec 25, 2018

Surprise!

@zmofei
Copy link

@zmofei zmofei commented Dec 25, 2018

A good library, just because of a Christmas egg, sympathy.

@gitchennan
Copy link

@gitchennan gitchennan commented Dec 25, 2018

鍐欒繖涓唬鐮佺殑浜虹湡鐨勫緢娌℃湁姘村噯锛岄潬杩欑鏂瑰紡鍗氫汉鐪肩悆锛屼笉閰嶄綔涓虹▼搴忓憳锛岀畝鐩存槸涓㈤樋閲岀殑鑴

@fireflyhoo
Copy link

@fireflyhoo fireflyhoo commented Dec 25, 2018

Be in awe of Allah

@zhansingsong
Copy link

@zhansingsong zhansingsong commented Dec 25, 2018

take it easy! big bro, not a big deal.
BTW, Recommend a grammar and spell checker for you, a chrome plugin: Grammarly for Chrome

@Shawn-ye
Copy link

@Shawn-ye Shawn-ye commented Dec 25, 2018

I think you could fix your typos first...

@devnkong
Copy link

@devnkong devnkong commented Dec 25, 2018

No offense bro, but you really need to correct your typos. I think some extensions may be helpful, like Grammarly.

@12Tall
Copy link

@12Tall 12Tall commented Dec 25, 2018

鑰佸摜浣 christmas 杩樻槸鎷奸敊浜嗐

鍝堝搱鍝堝搱鍝堝搱鍝堝搱鍝堝搱鍝堝搱鍝堝搱鍝堝搱

@afc163 afc163 changed the title 馃巺 About the Chrismas egg and workaround 馃巺 About the Christmas egg and workaround Dec 25, 2018
@latifrons
Copy link

@latifrons latifrons commented Dec 25, 2018

Should I submit a pull request to fix your grammar and typo.

my commit 00aebeb [on] Sep 10th
happend -> happened
It is a complete stupid decesion of my owner and very sorry to everyone that get involved. [No. "decesion" is not sorry, you are sorry. And you should always SAY sorry to someone.]
Are there -> Will there be
We are open source projest [No you are not open source nor projest, your project antd is]

@ZJM6658
Copy link

@ZJM6658 ZJM6658 commented Dec 25, 2018

鍦ㄨ繖涓瘨鍐风殑鍐ぉ锛屾劅鍙楀埌浜嗕竴涓濇殩鎰忥紝鎴戝厛鍥炲杩囧勾浜

@c0ming
Copy link

@c0ming c0ming commented Dec 25, 2018

澶у鎰ゆ掔殑鏄竴绉嶈寮哄ジ鐨勬劅瑙

@SergeyVolynkin
Copy link

@SergeyVolynkin SergeyVolynkin commented Dec 25, 2018

Yeah, imagine getting that on production in some serious Bank! >.<

@heeeeeng
Copy link

@heeeeeng heeeeeng commented Dec 25, 2018

Hahahahahaha.
Solve the problem, and Merry Christmas!

@FurshawFu
Copy link

@FurshawFu FurshawFu commented Dec 25, 2018

鍦ㄨ繖涓瘨鍐风殑鍐ぉ锛屾劅鍙楀埌浜嗕竴涓濇殩鎰忥紝鎴戝厛鍥炲杩囧勾浜
you such a PPXIA

@Xuralyon
Copy link

@Xuralyon Xuralyon commented Dec 25, 2018

鍐欒繖涓唬鐮佺殑浜虹湡鐨勫緢娌℃湁姘村噯锛岄潬杩欑鏂瑰紡鍗氫汉鐪肩悆锛屼笉閰嶄綔涓虹▼搴忓憳锛岀畝鐩存槸涓㈤樋閲岀殑鑴

楹荤儲鍒妸濞变箰鍦堝紡鍚愭Ы甯﹀埌杩欓噷鏉

@silentred
Copy link

@silentred silentred commented Dec 25, 2018

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

What a horrible catastrophe it is.

@zssjz
Copy link

@zssjz zssjz commented Dec 25, 2018

浜嬪凡鑷虫锛屾棤璁烘庝箞琛ㄨ揪鎰ゆ掗兘涓嶈兘鎸藉洖鎹熷け锛涗綔涓篴ntd鐨勪娇鐢ㄨ咃紝鎴戜篃瀵归犳垚鐨勫悗鏋滄劅鍒版儖鎯滐紝瀵硅繃婵鐨勮█璁鸿〃绀哄瘨蹇冿紱鎴戣繕鏄笇鏈沘ntd鑳界户缁帹鍑哄ソ鐨勪骇鍝侊紝涔熷笇鏈涗綔鑰呬笉瑕佸洜涓哄湥璇炶妭浜嬩欢鏈変粈涔堝お澶氱殑璐熼潰褰卞搷锛涗絾杩樻槸甯屾湜浠婂悗鑳藉鏂硅冭檻鍚庢灉锛屼负骞垮ぇ寮鍙戣呭甫鏉ョ溂鍓嶄竴浜殑浣滃搧銆

@joesonw
Copy link
Contributor

@joesonw joesonw commented Dec 25, 2018

take an easy! big bro, not a big deal.
BTW, Recommend a grammar and spell checker for you, a chrome plugin: Grammarly for Chrome

take an easy -> take it easy
big bro -> bro
not a big deal -> it's not a big deal
Recommend -> I recommend

杩欐彃浠朵篃涓嶅拫鍦板槢

@wellenzhong
Copy link

@wellenzhong wellenzhong commented Dec 25, 2018

Foreign friends are much friendlier than our Chinese guys.
anyway, thank you guys for your hard work!

@iwasa-kosui
Copy link

@iwasa-kosui iwasa-kosui commented Dec 25, 2018

Hmm, I think that this page is not an English classroom...
How about focusing our eyes on codes and features?

@flyfox11
Copy link

@flyfox11 flyfox11 commented Dec 25, 2018

鍦h癁鎸夐挳涓鏈典簯锛岃彍楦熻惤杩涗簡鑱婂ぉ缇わ紝婊″睆閮芥槸绋嬪簭姹夛紝璋佷慨bug璋佷涪榄

@252405649
Copy link

@252405649 252405649 commented Dec 25, 2018

鍐欒繖涓唬鐮佺殑浜虹湡鐨勫緢娌℃湁姘村噯锛岄潬杩欑鏂瑰紡鍗氫汉鐪肩悆锛屼笉閰嶄綔涓虹▼搴忓憳锛岀畝鐩存槸涓㈤樋閲岀殑鑴

鍙兘浣犱笉鏄▼搴忓憳锛屾墠鍙互璇村嚭杩欐牱鐨勮瘽銆傚皬閿欙紝鏀逛簡灏卞ソ

@kangkai124
Copy link

@kangkai124 kangkai124 commented Dec 25, 2018

鑰佸摜浣 christmas 杩樻槸鎷奸敊浜嗐
浣犳槸榄旈鍚...

@Zheaoli
Copy link

@Zheaoli Zheaoli commented Dec 25, 2018

璁ょ湡鐨勮锛岃繖娆℃渶鍧忕殑鎯呭喌涓嬶紝鏈変娇鐢ㄨ呰鍔濋鏄渶濂界殑缁撴灉
鏈鍧忕殑缁撴灉鏄湁浣跨敤鑰呰妫瀵熼櫌浠ユ笌鑱岀姜鎴栬呯牬鍧忎俊鎭郴缁熺姜鎻愯捣鍒戜簨璇夎浜

@zhansingsong
Copy link

@zhansingsong zhansingsong commented Dec 25, 2018

take an easy! big bro, not a big deal.
BTW, Recommend a grammar and spell checker for you, a chrome plugin: Grammarly for Chrome

take an easy 鏄暐鎰忔濓紝姝囨伅涓涓嬶紵take it easy
big bro 鏄彟璧蜂竴鍙ヤ簡锛屽簲璇ユ槸 Big bro, ...
Recommend 鍙ュ唴锛屼笉搴旇澶у啓棣栧瓧姣嶅惂
浣犵敤浜嗚繖涓彃浠舵病

鍝堝搱锛屽按灏笩銆傚畬鏁村姛鑳介渶瑕佷粯璐癸紝绌峰睂涓濅竴鏋馃槅銆備笉杩囨彃浠舵暣浣撲綋楠岃繕鏄笉閿欑殑銆

@M1seRy
Copy link

@M1seRy M1seRy commented Dec 25, 2018

chrismas -> christmas
decesion -> decision
of my owner -> of my own
projest -> project

and there're too many grammar errors as well...

Grammarly is a good tool for making sure everything you typed is right.

@GabrielCheung128
Copy link

@GabrielCheung128 GabrielCheung128 commented Dec 25, 2018

Didn't upgrade to the corresponding version, so wasn't impacted by this.
But how could that be merged if it was only your decision? And how you responded to those who raised the issue first was quite ridiculous as well as offensive.
You guys should take it serious on code review, or somebody somewhere in the world would lose his job, that's NOT FUN at all.

Still, Merry Christmas.

@Lilysunstrider
Copy link

@Lilysunstrider Lilysunstrider commented Dec 25, 2018

Es Yotube tod us: if yo rite anysing un yor coputer, yo ned Gramarly. Marry Chrismas!

@zhenghangjie
Copy link
Contributor

@zhenghangjie zhenghangjie commented Dec 25, 2018

reverence for this issue

@ipv4sec
Copy link

@ipv4sec ipv4sec commented Dec 25, 2018

鎯婇椈 antd 鍙戠敓浜 鍦h癁鑺傚僵铔嬩簨浠讹紝璧剁揣鍘绘鏌ヤ簡涓閬嶆墍鏈夐」鐩紝杩樺ソ鐗堟湰閮借緝浣庢病鏈夊彂鐢熸晠闅滐紝鍘诲畼缃戣鎽╀簡涓涓嬶紝button 涓婄殑浜戝僵鐨勭‘澶熸儕鑹筹紝璇村埌浜戝僵锛屾垜灏辨兂璧风瓔鏂椾簯鍜屽瓩鎮熺┖锛屾槑骞村勾鍒濓紝涓編鍚堟媿鐨勮タ娓歌鍗冲皢姝e紡寮鏈猴紝鎴戠户缁壆婕旂編鐚寸帇瀛欐偀绌猴紝鎴戜細鐢ㄧ編鐚寸帇鑹烘湳褰㈣薄鍔姏鍒涢犱竴涓鑳介噺鐨勫舰璞★紝鏂囦綋涓ゅ紑鑺憋紝寮樻壃涓崕鏂囧寲锛屽笇鏈涘ぇ瀹跺澶氬叧娉ㄣ

@JunYang-tes
Copy link

@JunYang-tes JunYang-tes commented Dec 25, 2018

鍚庢帓鍚冪摐銆

@devcui
Copy link

@devcui devcui commented Dec 25, 2018

鍚庢帓鍋峰伔鍗栫墖鍎...鍔犲井淇xxxx
I'm in the back row to sell some dvd of sexxxxx~~~

@hunterhug
Copy link

@hunterhug hunterhug commented Dec 25, 2018

I want to see that egg, can anyone tell me where.....

pity egg~~~

@Albuseven
Copy link

@Albuseven Albuseven commented Dec 25, 2018

I want to see that egg, can anyone tell me where .....

https://mobile.ant.design/

@hunterhug
Copy link

@hunterhug hunterhug commented Dec 25, 2018

I want to see that egg, can anyone tell me where .....

https://mobile.ant.design/

Ho HO HO~~~

@Gongziyu666
Copy link

@Gongziyu666 Gongziyu666 commented Dec 25, 2018

鎹㈠湴鏂瑰洿瑙傦紵

@edward-tes
Copy link

@edward-tes edward-tes commented Dec 25, 2018

This egg is so big and so round.

@feichangtutu
Copy link

@feichangtutu feichangtutu commented Dec 25, 2018

Are there same events happend in future?
鏄釜鐥呭彞鍟娾︹

@lzfgnu
Copy link

@lzfgnu lzfgnu commented Dec 25, 2018

鎯婇椈 antd 鍙戠敓浜 鍦h癁鑺傚僵铔嬩簨浠讹紝璧剁揣鍘绘鏌ヤ簡涓閬嶆墍鏈夐」鐩紝杩樺ソ鐗堟湰閮借緝浣庢病鏈夊彂鐢熸晠闅滐紝鍘诲畼缃戣鎽╀簡涓涓嬶紝button 涓婄殑浜戝僵鐨勭‘澶熸儕鑹筹紝璇村埌浜戝僵锛屾垜灏辨兂璧风瓔鏂椾簯鍜屽瓩鎮熺┖锛屾槑骞村勾鍒濓紝涓編鍚堟媿鐨勮タ娓歌鍗冲皢姝e紡寮鏈猴紝鎴戠户缁壆婕旂編鐚寸帇瀛欐偀绌猴紝鎴戜細鐢ㄧ編鐚寸帇鑹烘湳褰㈣薄鍔姏鍒涢犱竴涓鑳介噺鐨勫舰璞★紝鏂囦綋涓ゅ紑鑺憋紝寮樻壃涓崕鏂囧寲锛屽笇鏈涘ぇ瀹跺澶氬叧娉ㄣ

璋㈢姜鍚э紝鑰佸摜

@cbangchen
Copy link

@cbangchen cbangchen commented Dec 25, 2018

are You gAys ookkk ???

@devcui
Copy link

@devcui devcui commented Dec 25, 2018

鎯婇椈 antd 鍙戠敓浜 鍦h癁鑺傚僵铔嬩簨浠讹紝璧剁揣鍘绘鏌ヤ簡涓閬嶆墍鏈夐」鐩紝杩樺ソ鐗堟湰閮借緝浣庢病鏈夊彂鐢熸晠闅滐紝鍘诲畼缃戣鎽╀簡涓涓嬶紝button 涓婄殑浜戝僵鐨勭‘澶熸儕鑹筹紝璇村埌浜戝僵锛屾垜灏辨兂璧风瓔鏂椾簯鍜屽瓩鎮熺┖锛屾槑骞村勾鍒濓紝涓編鍚堟媿鐨勮タ娓歌鍗冲皢姝e紡寮鏈猴紝鎴戠户缁壆婕旂編鐚寸帇瀛欐偀绌猴紝鎴戜細鐢ㄧ編鐚寸帇鑹烘湳褰㈣薄鍔姏鍒涢犱竴涓鑳介噺鐨勫舰璞★紝鏂囦綋涓ゅ紑鑺憋紝寮樻壃涓崕鏂囧寲锛屽笇鏈涘ぇ瀹跺澶氬叧娉ㄣ

鍚戝叏鍥戒汉姘戣阿缃惂

@FurshawFu
Copy link

@FurshawFu FurshawFu commented Dec 25, 2018

@afc163 楹荤儲鍏抽棴涓涓嬶紝杩欎竴涓嬪崍鍨冨溇閭欢宸茬粡澶熷浜嗐

@rootkiter
Copy link

@rootkiter rootkiter commented Dec 25, 2018

Good job!

@ant-design ant-design locked and limited conversation to collaborators Dec 25, 2018
@afc163 afc163 closed this Dec 26, 2018
@afc163 afc163 unpinned this issue Dec 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet