New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 16 #5377

Closed
NE-SmallTown opened this Issue Mar 18, 2017 · 37 comments

Comments

Projects
None yet
@NE-SmallTown
Contributor

NE-SmallTown commented Mar 18, 2017

#I notice that at react-conf linclark make a speech about react-fiber,though dan has post a few videos on youtube recent months.This means that it will release soon, although it still hasn't done 100%,but now it has been alpha.4.

So,I notice that there are many old or compatible components,methods,styles etc in antd,I agree with that they are important.But back to now and forward to the future,both for antd and ourselfs,we nedd to research something such as [Fiber] Umbrella for remaining features / bugs, React 15.5 and 16 Umbrella (there are many concepts and new things so I can't list all of them,if you want to know,just search the '[Fiber]' as the key in React repo).

We should know which methods or concepts will be removed,such as Plan for Addons in React 16 and what we can do to improve though fiber has been doing much and huge perf optimize for us and most of current api won't change.

So,IMO,I think maybe we can think about how to refactor from now,of course react team will post change log and upgrade guide,but we still need to go in depth to make us understand better.

Finally,I know it will spend long time and much energy to do it,but “The first step is always difficult".Hope this will helps.


Edited by @benjycui

A list of react-component that we need to make them support React@16

  • rc-animate
  • rc-calendar
  • rc-cascader
  • rc-checkbox
  • rc-collapse
  • rc-dialog
  • rc-dropdown
  • rc-editor-mention
  • rc-form
  • rc-input-number
  • rc-menu react-component/menu#99
  • rc-notification react-component/notification#21 #7844
  • rc-pagination
  • rc-progress
  • rc-rate
  • rc-select
  • rc-slider
  • rc-steps
  • rc-switch
  • rc-table
  • rc-tabs
  • rc-time-picker
  • rc-tooltip
  • rc-tree
  • rc-tree-select
  • rc-upload
  • rc-util
@afc163

This comment has been minimized.

Show comment
Hide comment
@afc163

afc163 Mar 20, 2017

Member

Yes, we can create new branch and update react to 16 Umbrella, and see what we can do at this moment.

Member

afc163 commented Mar 20, 2017

Yes, we can create new branch and update react to 16 Umbrella, and see what we can do at this moment.

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Mar 20, 2017

Contributor

Yup,to be honest,I am too busy to go in depth into react-fiber,just hope this reminder would help 😃

Contributor

NE-SmallTown commented Mar 20, 2017

Yup,to be honest,I am too busy to go in depth into react-fiber,just hope this reminder would help 😃

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Mar 20, 2017

Contributor

Maybe we need notice this because we have much animation.

Contributor

NE-SmallTown commented Mar 20, 2017

Maybe we need notice this because we have much animation.

@afc163 afc163 changed the title from Plans in the future to [Fiber] support React Umbrella Mar 21, 2017

@adidahiya adidahiya referenced this issue Mar 21, 2017

Closed

React 16 support #866

3 of 3 tasks complete
@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Mar 22, 2017

Contributor

react 16 will remove React.createClass

relevant pr and more details

I remember that before someone has discussed that change all ES5 syntax to ES6 in react-component and of course we need much time to do that.So,just for memo.

Contributor

NE-SmallTown commented Mar 22, 2017

react 16 will remove React.createClass

relevant pr and more details

I remember that before someone has discussed that change all ES5 syntax to ES6 in react-component and of course we need much time to do that.So,just for memo.

@benjycui

This comment has been minimized.

Show comment
Hide comment
@benjycui

benjycui Mar 22, 2017

Contributor

There is no React.createClass in antd now, but react-component had use lots of React.createClass

You can grep to make sure this point.

Contributor

benjycui commented Mar 22, 2017

There is no React.createClass in antd now, but react-component had use lots of React.createClass

You can grep to make sure this point.

@afc163

This comment has been minimized.

Show comment
Hide comment
@afc163

afc163 Mar 22, 2017

Member

There are lots of work~

Member

afc163 commented Mar 22, 2017

There are lots of work~

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Mar 22, 2017

Contributor

@benjycui Yep,update comment.Sorry for that I don't describe very clear,my actual meaning is that antd relys on react-component,so if react-component doesn't change,so antd's update will be limited too.

Contributor

NE-SmallTown commented Mar 22, 2017

@benjycui Yep,update comment.Sorry for that I don't describe very clear,my actual meaning is that antd relys on react-component,so if react-component doesn't change,so antd's update will be limited too.

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Mar 22, 2017

Contributor

@afc163 Yeah,everyone is the same.Maybe make it to our goal this year? 😄

Contributor

NE-SmallTown commented Mar 22, 2017

@afc163 Yeah,everyone is the same.Maybe make it to our goal this year? 😄

@monkindey

This comment has been minimized.

Show comment
Hide comment
@monkindey

monkindey Mar 22, 2017

Contributor

Can this one helps? Or be inspired from it?

Contributor

monkindey commented Mar 22, 2017

Can this one helps? Or be inspired from it?

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Mar 22, 2017

Contributor

@monkindey I almost forget it.Thanks!But so far I don't use it,so have no experience on it.Waiting evaluation of members~

Contributor

NE-SmallTown commented Mar 22, 2017

@monkindey I almost forget it.Thanks!But so far I don't use it,so have no experience on it.Waiting evaluation of members~

@monkindey

This comment has been minimized.

Show comment
Hide comment
@monkindey

monkindey Mar 22, 2017

Contributor

yep, I think there will be some unpredictable situation using it, but may be we can learn something from it.

Contributor

monkindey commented Mar 22, 2017

yep, I think there will be some unpredictable situation using it, but may be we can learn something from it.

@monkindey

This comment has been minimized.

Show comment
Hide comment
@monkindey

monkindey Mar 22, 2017

Contributor

According to dan twitter and acdlite pr, may be we can import the react-create-class package, no need to rewrite anything.

Contributor

monkindey commented Mar 22, 2017

According to dan twitter and acdlite pr, may be we can import the react-create-class package, no need to rewrite anything.

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown
Contributor

NE-SmallTown commented May 11, 2017

onChange -> onInput, and don't polyfill onInput for uncontrolled components

This maybe is just a idea,so just for reminding

@NE-SmallTown

This comment has been minimized.

Show comment
Hide comment
@NE-SmallTown

NE-SmallTown Sep 15, 2017

Contributor

From this tweet, it seems that maybe we need refactor Modal or other components(I don't dig into the src code so I am not sure whether we have the usage like in the tweet).

And there are 2 codepens you can view the difference:

before(react 15)

now(react 16)

cc @afc163 @benjycui

And there will be internal warning of react and documentation when react16 release, so this is just a tip.

relevant pr: facebook/react#10730


now, all things landed! https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html

Contributor

NE-SmallTown commented Sep 15, 2017

From this tweet, it seems that maybe we need refactor Modal or other components(I don't dig into the src code so I am not sure whether we have the usage like in the tweet).

And there are 2 codepens you can view the difference:

before(react 15)

now(react 16)

cc @afc163 @benjycui

And there will be internal warning of react and documentation when react16 release, so this is just a tip.

relevant pr: facebook/react#10730


now, all things landed! https://facebook.github.io/react/blog/2017/09/26/react-v16.0.html

@monkindey

This comment has been minimized.

Show comment
Hide comment
@monkindey

monkindey Sep 18, 2017

Contributor

Related usage information

facebook/react#10309 (comment)

Now you can use createPortal instead of unstable_createPortal

Contributor

monkindey commented Sep 18, 2017

Related usage information

facebook/react#10309 (comment)

Now you can use createPortal instead of unstable_createPortal

@wangyazhen

This comment has been minimized.

Show comment
Hide comment
@wangyazhen

wangyazhen Sep 19, 2017

Keep an eye on

wangyazhen commented Sep 19, 2017

Keep an eye on

@afc163

This comment has been minimized.

Show comment
Hide comment
@afc163
Member

afc163 commented Sep 30, 2017

@afc163 afc163 changed the title from [Fiber] support React Umbrella to [Fiber] support React 16 Sep 30, 2017

@afc163 afc163 changed the title from [Fiber] support React 16 to Support React 16 Sep 30, 2017

@pdeva

This comment has been minimized.

Show comment
Hide comment
@pdeva

pdeva Oct 6, 2017

considering all linked issues are closed, can we mark this issue as closed and do a release 2.13.5 with React 16 supported?...

pdeva commented Oct 6, 2017

considering all linked issues are closed, can we mark this issue as closed and do a release 2.13.5 with React 16 supported?...

@malekjaroslav

This comment has been minimized.

Show comment
Hide comment
@malekjaroslav

malekjaroslav Oct 7, 2017

That would be awesome!

malekjaroslav commented Oct 7, 2017

That would be awesome!

@abenhamdine

This comment has been minimized.

Show comment
Hide comment
@abenhamdine

abenhamdine Oct 10, 2017

Contributor

considering all linked issues are closed, can we mark this issue as closed and do a release 2.13.5 with React 16 supported?...

I don't think it's sufficient, every rc component listed at the top of this thread has to be updated in order to support react16.

Contributor

abenhamdine commented Oct 10, 2017

considering all linked issues are closed, can we mark this issue as closed and do a release 2.13.5 with React 16 supported?...

I don't think it's sufficient, every rc component listed at the top of this thread has to be updated in order to support react16.

@ZheyangSong

This comment has been minimized.

Show comment
Hide comment
@ZheyangSong

ZheyangSong Oct 10, 2017

Tracking...Really need to see support to react-fiber.

ZheyangSong commented Oct 10, 2017

Tracking...Really need to see support to react-fiber.

yesmeck referenced this issue in react-component/trigger Oct 16, 2017

@yesmeck

This comment has been minimized.

Show comment
Hide comment
@yesmeck

yesmeck Oct 16, 2017

Member

A highlight note after upgrading to React 16 (See https://github.com/react-component/trigger#react-16-note), some components rely on rc-trigger or using ReactDom.createPortal will introduce a breaking change.

Member

yesmeck commented Oct 16, 2017

A highlight note after upgrading to React 16 (See https://github.com/react-component/trigger#react-16-note), some components rely on rc-trigger or using ReactDom.createPortal will introduce a breaking change.

@pencilcheck

This comment has been minimized.

Show comment
Hide comment
@pencilcheck

pencilcheck Oct 16, 2017

Is there any workaround for now to use react 16 with antd?

pencilcheck commented Oct 16, 2017

Is there any workaround for now to use react 16 with antd?

@Harrisonl

This comment has been minimized.

Show comment
Hide comment
@Harrisonl

Harrisonl Oct 21, 2017

Just wondering if there is a way branch that gets react 16 working with antd yet? Or an estimated date? Love the library and the support you guys provide and would love to see it grow with the react community.

Harrisonl commented Oct 21, 2017

Just wondering if there is a way branch that gets react 16 working with antd yet? Or an estimated date? Love the library and the support you guys provide and would love to see it grow with the react community.

@abenhamdine

This comment has been minimized.

Show comment
Hide comment
@abenhamdine

abenhamdine Oct 23, 2017

Contributor

rc-time-picker can be checked, see react-component/time-picker@fd231e0

Contributor

abenhamdine commented Oct 23, 2017

rc-time-picker can be checked, see react-component/time-picker@fd231e0

@afc163

This comment has been minimized.

Show comment
Hide comment
@afc163

afc163 Oct 23, 2017

Member

Not yet until we upgrade rc-time-picker version in branch antd-3.0.

Member

afc163 commented Oct 23, 2017

Not yet until we upgrade rc-time-picker version in branch antd-3.0.

@abenhamdine

This comment has been minimized.

Show comment
Hide comment
@abenhamdine

abenhamdine Oct 23, 2017

Contributor

Not yet until we upgrade rc-time-picker version in branch antd-3.0.

ah ok sorry for the noise

Contributor

abenhamdine commented Oct 23, 2017

Not yet until we upgrade rc-time-picker version in branch antd-3.0.

ah ok sorry for the noise

@RaoHai

This comment has been minimized.

Show comment
Hide comment
@RaoHai
Contributor

RaoHai commented Nov 7, 2017

@yesmeck

This comment has been minimized.

Show comment
Hide comment
@yesmeck

yesmeck Nov 13, 2017

Member

All rc-component antd relied on have upgraded to React 16.

Member

yesmeck commented Nov 13, 2017

All rc-component antd relied on have upgraded to React 16.

@yesmeck yesmeck closed this Nov 13, 2017

@malekjaroslav

This comment has been minimized.

Show comment
Hide comment
@malekjaroslav

malekjaroslav Nov 13, 2017

@yesmeck will there be an update of dependencies in antd?

malekjaroslav commented Nov 13, 2017

@yesmeck will there be an update of dependencies in antd?

@yesmeck

This comment has been minimized.

Show comment
Hide comment
@yesmeck

yesmeck Nov 13, 2017

Member

Yes, we are updating dependencies, #8150

Member

yesmeck commented Nov 13, 2017

Yes, we are updating dependencies, #8150

@int64ago

This comment has been minimized.

Show comment
Hide comment
@int64ago

int64ago Nov 13, 2017

Contributor

@yesmeck Any plan for release date ?

Contributor

int64ago commented Nov 13, 2017

@yesmeck Any plan for release date ?

@yesmeck

This comment has been minimized.

Show comment
Hide comment
@yesmeck

yesmeck Nov 13, 2017

Member

The end of this month.

Member

yesmeck commented Nov 13, 2017

The end of this month.

@damiangreen

This comment has been minimized.

Show comment
Hide comment
@damiangreen

damiangreen Dec 1, 2017

Contributor

Was this released? Which version?

Contributor

damiangreen commented Dec 1, 2017

Was this released? Which version?

@iugo

This comment has been minimized.

Show comment
Hide comment
@feibi

This comment has been minimized.

Show comment
Hide comment
@feibi

feibi Mar 7, 2018

record it, form still warn it

feibi commented Mar 7, 2018

record it, form still warn it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment