New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker & MonthPicker should not use selected style when user haven't selected value #6146

Closed
benjycui opened this Issue May 15, 2017 · 10 comments

Comments

Projects
None yet
7 participants
@benjycui
Contributor

benjycui commented May 15, 2017

Current style is wrong:

image

This is right:

image

@infeng

This comment has been minimized.

Contributor

infeng commented May 16, 2017

rel #4071

@benjycui

This comment has been minimized.

Contributor

benjycui commented May 16, 2017

这个不一样的吧,真正的问题是,用户没选择之前,今天那个 cell 不应该有 ant-calendar-selected-day 这个样式。

@infeng

This comment has been minimized.

Contributor

infeng commented May 16, 2017

那就是『键盘操作的当前日期』和『选中日期』的样式要分开

@benjycui

This comment has been minimized.

Contributor

benjycui commented May 17, 2017

关联内部 ued/ant-design#202 ,还需讨论,先 pending

@afc163

This comment has been minimized.

Member

afc163 commented Jun 16, 2017

It is not selected date, it is a keyboard-active date.

@afc163

This comment has been minimized.

Member

afc163 commented Jun 16, 2017

Discussed this before: react-component/calendar#30

@benjycui

This comment has been minimized.

Contributor

benjycui commented Jun 19, 2017

image

Blue font and white background means today, white font and blue background means active.

So, no special style for selected date?

@afc163

This comment has been minimized.

Member

afc163 commented Jun 19, 2017

Yes, we need one more style for selected date or new active style.

@supra28

This comment has been minimized.

Contributor

supra28 commented Jun 27, 2017

shouldn't active and selected represent the same thing?

@xiaoqing-tan

This comment has been minimized.

xiaoqing-tan commented Mar 9, 2018

The issue still exists when I use DatePicker set showTime as true, then I click 'OK' nothing was changed in input box.

'ant-calendar-selected-day', should be removed in that element when nothing was selected.

bors bot added a commit to mozilla/delivery-console that referenced this issue Jul 10, 2018

Merge #295
295: Update dependency antd to v3.6.6 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.6.5` to `v3.6.6`



<details>
<summary>Release Notes</summary>

### [`v3.6.6`](https://github.com/ant-design/ant-design/releases/3.6.6)
[Compare Source](ant-design/ant-design@3.6.5...3.6.6)
- 🐞 Fix the style of the selected day for `DatePicker`. [#&#8203;6146](`ant-design/ant-design#6146) [#&#8203;9529](`ant-design/ant-design#9529)
- 🐞 Fix the style of the selected day for `DatePicker.RangePicker`. [004561b](ant-design/ant-design@004561b)
- 🐞 Fix the alignment style wrapped by `Form.Item` for `Cascader`. [#&#8203;9827](`ant-design/ant-design#9827) [#&#8203;11133](`ant-design/ant-design#11133)
- 🐞 Fix the background style of the `handler` for `InputNumber`. [4aabc53](ant-design/ant-design@4aabc53)
- 🐞 Fix the header overflow in `FireFox` when the data is empty for `Table`. [#&#8203;11135](`ant-design/ant-design#11135)


---


- 🐞 修复 `DatePicker` 组件被选中日期的样式问题。[#&#8203;6146](`ant-design/ant-design#6146) [#&#8203;9529](`ant-design/ant-design#9529)
- 🐞 修复 `DatePicker.RangePicker` 组件中被选中日期的样式问题。[004561b](ant-design/ant-design@004561b)
- 🐞 修复 `Cascader` 组件在 `Form.Item` 下的对齐问题。[#&#8203;9827](`ant-design/ant-design#9827) [#&#8203;11133](`ant-design/ant-design#11133)
- 🐞 修复 `InputNumber` 组件的 `handler` 的背景样式问题。[4aabc53](ant-design/ant-design@4aabc53)
- 🐞 修复 `Table` 组件在 `FireFox` 浏览器下数据为空时的头部溢出的样式问题。[#&#8203;11135](`ant-design/ant-design#11135)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment