New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid width property on notification message #8437

Closed
alekseychaikovsky opened this Issue Dec 4, 2017 · 2 comments

Comments

Projects
None yet
5 participants
@alekseychaikovsky

alekseychaikovsky commented Dec 4, 2017

Version

3.0.0

Environment

all

Reproduction link

https://github.com/ant-design/ant-design/blob/master/components/notification/style/index.less#L47

Steps to reproduce

We are using postcss and also ant design. when upgrade to 3.0.0 antd.css produce invalid css causing postcss loader to crash.
The issue is with this line. https://github.com/ant-design/ant-design/blob/master/components/notification/style/index.less#L47
compiled css looks like
width: calc(384px - 16px 24px * 2 - 24px - 48px - 100%);

specifically this is not valid 16px 24px

example error message is

ERROR in ./node_modules/css-loader?{"sourceMap":true,"minimize":false}!./node_modules/postcss-loader/lib?{"config":{"path":"./tools/postcss.config.js"}}!./node_modules/antd/dist/antd.css
Module build failed: Parse error on line 1:
384px - 16px 24px * 2 - 24px - 48
-------------^
Expecting 'EOF', 'ADD', 'SUB', 'MUL', 'DIV', 'RPAREN', got 'LENGTH'

What is expected?

The width property is valid

What is actually happening?

The width property is not valid


Ran into this bug while upgrading to latest ant version (3.0.0)

@yesmeck yesmeck added the Bug🐛 label Dec 5, 2017

@mosaice

This comment has been minimized.

mosaice commented Dec 5, 2017

same problem in my project
i try to import source less file ~antd/dist/antd.less but it failed

@vimniky

This comment has been minimized.

vimniky commented Dec 6, 2017

The same problem !

@afc163 afc163 self-assigned this Dec 6, 2017

@afc163 afc163 closed this in 0402e03 Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment