New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve type name collisions #8478

Closed
hackape opened this Issue Dec 6, 2017 · 6 comments

Comments

Projects
None yet
4 participants
@hackape

hackape commented Dec 6, 2017

What problem does this feature solve?

  • Type { InputProps } from 'antd/lib/auto-complete' collide with { InputProps } from 'antd/lib/input'
  • rename { SearchProps } from 'antd/lib/transfer' collide with { SearchProps } from 'antd/lib/input'

What does the proposed API look like?

  • rename { InputProps } from 'antd/lib/auto-complete' to { AutoCompleteInputProps }
  • rename { SearchProps } from 'antd/lib/transfer' to { TransferSearchProps }
@yesmeck

This comment has been minimized.

Member

yesmeck commented Dec 6, 2017

Why they are conflicting? These interfaces in different module.

@GauravV-02

This comment has been minimized.

Contributor

GauravV-02 commented Dec 10, 2017

@hackape Can I work on this?

@yesmeck

This comment has been minimized.

Member

yesmeck commented Dec 10, 2017

@GauravV-02 Yes, but can you answer my question?

@GauravV-02

This comment has been minimized.

Contributor

GauravV-02 commented Dec 10, 2017

@yesmeck I haven't looked it why its conflicting yet. Lets think we have a module where I have to import both the interfaces from input and auto complete, It will give an duplicate identifier error because the names of the interfaces are same.

@yesmeck

This comment has been minimized.

Member

yesmeck commented Dec 11, 2017

Hmm, make sense. welcome PR.

@hackape

This comment has been minimized.

hackape commented Dec 18, 2017

Sorry guys I totally missed out this thread.

@GauravV-02 yes that's exactly the case I ran into, I made a module layer that functions as a customization point, which effectively import, extend, then re-export everything. At the time I check, it's already merged, thank you for you effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment