Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upanchor won't work when anchor/link's href is a complete link (/somepath#id) #8808
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
ant-design-bot
Jan 3, 2018
It will be better to write your issue/comment in English, so more people can understand you.
And this means that more people can help you or benefit from your issue/comment.
See: #4897
ant-design-bot
commented
Jan 3, 2018
|
It will be better to write your issue/comment in English, so more people can understand you. |
jjzhangg
changed the title from
anchor无法支持href为完整url的情况
to
anchor won't work when anchor/link's href is a complete link (/somepath#id)
Jan 3, 2018
jjzhangg
referenced this issue
Jan 3, 2018
Merged
Bugfix for 2.x stable - anchor scroll supports complete href link #8807
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
dengfuping
Jan 3, 2018
Contributor
@jjzhangg The problem exists indeed when opened in codesandbox. But it's all right in codepen and riddle.
|
@jjzhangg The problem exists indeed when opened in codesandbox. But it's all right in codepen and riddle. |
dengfuping
added
Component: Anchor
Demo
labels
Jan 3, 2018
ant-design-bot
assigned
afc163
Jan 3, 2018
This was referenced Jan 4, 2018
afc163
closed this
in
#8826
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jjzhangg commentedJan 3, 2018
•
edited
Version
3.1.0
Environment
any
Reproduction link
https://codesandbox.io/s/o97wp51vmq
Steps to reproduce
just scroll page
What is expected?
some link of the anchor being active
What is actually happening?
none link being active
We introduced base tag in our html
<head><base href="/somebase">...<head>and with this setting, every #id, will be translated by browser into /somebase#id, not document.href#id. As a result, we need to specify anchor/link href as complete link.
But the current code of anchor, take href as #id by default, and will not work with a complete link like '/hello/world#id'.