Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subMenuCloseDelay and subMenuOpenDelay props are missing from Menu's type definitions #8976

Closed
maroun-baydoun opened this issue Jan 16, 2018 · 1 comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. TypeScript

Comments

@maroun-baydoun
Copy link

Version

3.1.3

Environment

N/A

Reproduction link

https://github.com/ant-design/ant-design/blob/master/components/menu/index.tsx#L29

Steps to reproduce

Using TypeScript, add a Menu component with subMenuCloseDelay and/or subMenuOpenDelay props. The code cannot be compiled because the type definitions do not include the above props.

What is expected?

The Menu component should accept the subMenuCloseDelay and subMenuOpenDelay props when using TypeScript

What is actually happening?

The type definitions for the Menu component, do not include the subMenuCloseDelay and subMenuOpenDelay props even though they are listed in the documentation.

@afc163 afc163 added TypeScript help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels Jan 16, 2018
@maroun-baydoun
Copy link
Author

@afc163 Actually the problem is not about missing types, but the source code of the Menu component is missing those props that are present in the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants