New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip around disabled Button leads to split inside of ButtonGroup #9296

Closed
saerdnaer opened this Issue Feb 7, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@saerdnaer

saerdnaer commented Feb 7, 2018

Version

3.2.0

Environment

Mac OS 10.12.6, Safari 10.1.2

Reproduction link

https://codepen.io/anon/pen/MQbybP?editors=0010

temp

Steps to reproduce

Create a ButtonGroup with three buttons, add Tooltip around first one. Disable first button.

    <ButtonGroup>
      <Tooltip title="This text explains what this button does">
        <Button disabled size="small">
          <Icon type="arrow-up" />
        </Button>
      </Tooltip>

      <Button size="small">
        <Icon type="copy" />
      </Button>

      <Button size="small" type="primary">
          <Icon type="edit" />
      </Button>
    </ButtonGroup>

What is expected?

ButtonGroup is visually not split.

What is actually happening?

ButtonGroup gets visually split and button gets rounded on the right.

@dengfuping

This comment has been minimized.

Contributor

dengfuping commented Feb 8, 2018

@saerdnaer Your tooltip is so long and there is no enough space on the left. It's designed for avoid that tooltip is out of the browser window. Just make tooltip shorter or leave enough space for tooltip.

@afc163 afc163 closed this in 70f3afe Feb 8, 2018

@saerdnaer

This comment has been minimized.

saerdnaer commented Feb 8, 2018

The problem I tried to highlight is not the text inside the tooltip but the extra pixels between the buttons:
temp

@afc163

This comment has been minimized.

Member

afc163 commented Feb 8, 2018

@saerdnaer I just fixed this problem in 70f3afe

@saerdnaer

This comment has been minimized.

saerdnaer commented Feb 8, 2018

Ah, looks like I got confused by the other comment, too – sorry for the noice.

@tangjinzhou

This comment has been minimized.

Contributor

tangjinzhou commented Jul 18, 2018

Still have similar problems.
https://codesandbox.io/s/61lqr2m4mr
image

zombieJ added a commit that referenced this issue Jul 21, 2018

fix: ButtonGroup style bug when have disabled button #9296 (#11321)
* fix: ButtonGroup style bug when have disabled button #9296

* Update mixin.less
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment