/ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Progress] successPercent display incorrectly when percent=100 #9382

Closed
knilink opened this Issue Feb 20, 2018 · 0 comments

Comments

Assignees

@yesmeck yesmeck

Labels
Projects
None yet
Milestone
No milestone
3 participants
@knilink @ant-design-bot @yesmeck
@knilink

knilink commented Feb 20, 2018 •
edited

Version

3.2.1

Environment

Version 64.0.3282.140 (Official Build) (64-bit)

Reproduction link

https://codesandbox.io/s/v5pn12lpl

Steps to reproduce

<Progress percent={100} successPercent={50} />

What is expected?

The progress bar is expected to be 50% green 50% blue.

What is actually happening?

100% green.

@ant-design-bot ant-design-bot added the Component: Progress label Feb 20, 2018

@ant-design-bot ant-design-bot assigned yesmeck Feb 20, 2018

@dengfuping dengfuping referenced this issue Feb 21, 2018

Closed

Fix: successPercent should decide the progress status when it exists, close #9382 #9385

@dengfuping dengfuping referenced this issue Mar 10, 2018

Merged

Fix: successPercent should decide the progress status when it exists, close #9382 #9614

@dengfuping dengfuping closed this in #9614 Mar 10, 2018

dengfuping added a commit that referenced this issue Mar 10, 2018

@dengfuping
Fix: successPercent should decide the progress status when it exists, c… 
…lose #9382 (#9614)

* fix: successPercent should decide the progress status when it exists, close #9382

* Add test for e361df0 that successPercent should decide the progress status when it exists
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
40e7e0c

This was referenced Mar 20, 2018

Closed
Closed

zheeeng added a commit to zheeeng/ant-design that referenced this issue Apr 12, 2018

@dengfuping @zheeeng
Fix: successPercent should decide the progress status when it exists, c… 
…lose ant-design#9382 (ant-design#9614)

* fix: successPercent should decide the progress status when it exists, close ant-design#9382

* Add test for e361df0 that successPercent should decide the progress status when it exists
45867f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment