/ant-design

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate component 'disabled' prop should have default cursor on hover #9747

Closed
avalanche1 opened this Issue Mar 20, 2018 · 1 comment

Comments

Assignees

@ddcat1115 ddcat1115

Labels
Projects
None yet
Milestone
No milestone
4 participants
@avalanche1 @dengfuping @ant-design-bot @ddcat1115
@avalanche1

avalanche1 commented Mar 20, 2018 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Rate component 'read-only' variation is mostly used when you want to display something, not give a rating. Thus, having cursor: not-allowed on hover is really an anti-pattern here. Why would someone wish to see a not-allowed cursor when hovering over a rating of a product for example?

What does the proposed API look like?

cursor: default on hover

@ant-design-bot ant-design-bot added the Component: Rate label Mar 20, 2018

@ant-design-bot ant-design-bot assigned ddcat1115 Mar 20, 2018

@dengfuping dengfuping added Feature Request and removed Feature Request labels Mar 21, 2018

@dengfuping

This comment has been minimized.

Sign in to view
Contributor

dengfuping commented Mar 21, 2018 •
edited

@avalanche1 Maybe we should rename disabled prop to readOnly prop and fix the cursor style.

@dengfuping dengfuping closed this in 3dcab87 Mar 21, 2018

@dengfuping dengfuping changed the title from Rate component 'read-only' variation should have default cursor on hover to Rate component 'disabled' prop should have default cursor on hover Mar 21, 2018

zheeeng added a commit to zheeeng/ant-design that referenced this issue Apr 12, 2018

@dengfuping @zheeeng
fix: cursor style of disabled Rate should be default, close ant-desig… 
…n#9747
428cc69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment