Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rate component 'disabled' prop should have default cursor on hover #9747

Closed
1 task done
avalanche1 opened this issue Mar 20, 2018 · 1 comment
Closed
1 task done

Rate component 'disabled' prop should have default cursor on hover #9747

avalanche1 opened this issue Mar 20, 2018 · 1 comment
Assignees
@ddcat1115

Comments

@avalanche1
Copy link

avalanche1 commented Mar 20, 2018 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

Rate component 'read-only' variation is mostly used when you want to display something, not give a rating. Thus, having cursor: not-allowed on hover is really an anti-pattern here. Why would someone wish to see a not-allowed cursor when hovering over a rating of a product for example?

What does the proposed API look like?

cursor: default on hover
@dengfuping
Copy link
Contributor

dengfuping commented Mar 21, 2018 •
edited

@avalanche1 Maybe we should rename disabled prop to readOnly prop and fix the cursor style.

@dengfuping dengfuping changed the title Rate component 'read-only' variation should have default cursor on hover Rate component 'disabled' prop should have default cursor on hover Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ddcat1115 ddcat1115

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ddcat1115 @avalanche1 @dengfuping @ant-design-bot