type error with react 16.3.1

[whtsky]

• I have searched the issues of this repository and believe that this is not a duplicate.

Version

3.3.3

Environment

@types/react 16.3.4 , antd 3.4.0

Reproduction link

https://github.com/whtsky/antd-react-16.3.1-type

Steps to reproduce

npx tsc

What is expected?

compile

What is actually happening?

node_modules/antd/lib/badge/ScrollNumber.d.ts(28,81): error TS2344: Type '{ className: string; style: { transition: string | boolean; msTransform: string; WebkitTransform:...' does not satisfy the constraint 'HTMLAttributes'.
Types of property 'style' are incompatible.
Type '{ transition: string | boolean; msTransform: string; WebkitTransform: string; transform: string; }' is not assignable to type 'CSSProperties'.
Types of property 'transition' are incompatible.
Type 'string | boolean' is not assignable to type 'string'.
Type 'true' is not assignable to type 'string'.
node_modules/antd/lib/badge/ScrollNumber.d.ts(38,77): error TS2344: Type '{ className: string; style: { transition: string | boolean; msTransform: string; WebkitTransform:...' does not satisfy the constraint 'HTMLAttributes'.
Types of property 'style' are incompatible.
Type '{ transition: string | boolean; msTransform: string; WebkitTransform: string; transform: string; }' is not assignable to type 'CSSProperties'.
Types of property 'transition' are incompatible.
Type 'string | boolean' is not assignable to type 'string'.
Type 'true' is not assignable to type 'string'.

[whtsky]

antd version is 3.4.0

[KevinWang15]

happens to me too.

antd: 3.4.0
react: 16.3.1
react-dom: 16.3.1
@types/react: 16.3.5
@types/react-dom: 16.0.4
typescript: 2.8.1

for the time being I edited node_modules/antd/lib/badge/ScrollNumber.d.ts
replacing all string | boolean with string

[yesmeck]

@whtsky I don't see codes in your repo.

[ant-design-bot]

Hello @whtsky. Please provide a online reproduction by forking this link https://u.ant.design/codesandbox-repro. Issues labeled by Need Reproduce will be closed if no activities in 7 days.

[KagamiChan]

@yesmeck It is antd's type definition (specifically, ScrollNumber.d.ts) that is incompatible with latest @types/react definition, running tsc will reproduce the issue.

IMO boolean value transition in component's style props does not make sense, so the latest @types/react is correct, and ScrollNumber.d.ts needs a fix

[whtsky]

@yesmeck We don't need any code to reproduce this problem. Simply import antd will cause type error.

[narrowizard]

@yesmeck same error to me.

[lucasriondel]

same here. changing transition: string | boolean; to transition: string; in ScrollNumber.d.ts line 31&41 did it for me though, thanks @KagamiChan .

[kanweiwei]

happens to me too.

[alesdrobysh]

@yesmeck are you planning to issue a patch release?

[afc163]

https://ant.design/changelog#Release-Schedule

[alesdrobysh]

@afc163 isn't it urgent? it is impossible to compile TS+react+antd app

[afc163]

You can try @types/react@~16.2.0 as workaround now.

[alesdrobysh]

@afc163 downgrading doesn't work if I have some @types/react-* dependencies;

for example @types/react-redux internally installs the latest react typings and it causes compilation failure

[KevinWang15]

@alesdrobysh You can try to modify node_modules/antd/lib/badge/ScrollNumber.d.ts and then use https://github.com/ds300/patch-package for now (refer to my previous comment)

[zheeeng]

Happens to me.

[bora89]

yes, the problem does exist

[pinguo-liuhongwei]

same here

[dfreire]

It happens to me too.

[lvlohammadi]

Is this an urgent issue?
Currently i cant make any changes in node_modules, Because it's runs on the gitlab pipeline.

[bora89]

According to their schedule they ought to do a release at the end of each week, so we would rather wait a bit

[alesdrobysh]

as a temporary solution it works to add skipLibCheck flag to tsconfig

[Rain120]

    我理解的更新之后的版本和新版的react可能不兼容，所以你可以将版本降下去，我的版本是@AntD 3.2.0, @types/react 16.0.25