New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix issue.9862 #10052

Merged
merged 2 commits into from Apr 20, 2018

Conversation

Projects
None yet
3 participants
@zheeeng
Contributor

zheeeng commented Apr 15, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Apr 15, 2018

Deploy preview for ant-design ready!

Built with commit 7af2dc8

https://deploy-preview-10052--ant-design.netlify.com

@afc163

This comment has been minimized.

Member

afc163 commented Apr 15, 2018

Rebase master to fix ci, and remove unrelated commits.

@zheeeng zheeeng force-pushed the zheeeng:bugfix-issue.9862 branch from 9a7febb to 7af2dc8 Apr 15, 2018

@codecov

This comment has been minimized.

codecov bot commented Apr 15, 2018

Codecov Report

Merging #10052 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10052      +/-   ##
==========================================
+ Coverage   86.28%   86.28%   +<.01%     
==========================================
  Files         197      197              
  Lines        4740     4741       +1     
  Branches     1321     1321              
==========================================
+ Hits         4090     4091       +1     
  Misses        647      647              
  Partials        3        3
Impacted Files Coverage Δ
components/card/index.tsx 84.93% <100%> (+0.2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b64a77...7af2dc8. Read the comment docs.

@afc163 afc163 merged commit 572ae5c into ant-design:master Apr 20, 2018

5 checks passed

codecov/patch 100% of diff hit (target 86.28%)
Details
codecov/project 86.28% (+<.01%) compared to 9b64a77
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details

afc163 referenced this pull request Apr 22, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Apr 22, 2018

More update about #9862: f4ae929

@zheeeng zheeeng deleted the zheeeng:bugfix-issue.9862 branch Apr 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment