New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new edit Table demo #10119

Merged
merged 7 commits into from May 7, 2018

Conversation

Projects
None yet
4 participants
@chenshuai2144
Contributor

chenshuai2144 commented Apr 17, 2018

更优雅的 edit Table demo

@chenshuai2144

This comment has been minimized.

Contributor

chenshuai2144 commented Apr 17, 2018

antd 也应该搞搞 perttier md 文件没有高亮。改 eslint 改了10来分钟

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Apr 17, 2018

Deploy preview for ant-design ready!

Built with commit 348b823

https://deploy-preview-10119--ant-design.netlify.com

@yesmeck

This comment has been minimized.

Member

yesmeck commented Apr 17, 2018

CI failed

@chenshuai2144

This comment has been minimized.

Contributor

chenshuai2144 commented Apr 17, 2018

神奇。。。
这个还有 test 我改一下

@afc163

This comment has been minimized.

Member

afc163 commented Apr 19, 2018

CI failed

@chenshuai2144 chenshuai2144 force-pushed the newEditTable branch from 5fefe3c to 56c9112 Apr 23, 2018

@chenshuai2144 chenshuai2144 force-pushed the newEditTable branch from 56c9112 to 062a097 May 2, 2018

@codecov

This comment has been minimized.

codecov bot commented May 2, 2018

Codecov Report

Merging #10119 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10119   +/-   ##
=======================================
  Coverage   86.47%   86.47%           
=======================================
  Files         196      196           
  Lines        4791     4791           
  Branches     1338     1338           
=======================================
  Hits         4143     4143           
  Misses        645      645           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e99a93...348b823. Read the comment docs.

@chenshuai2144 chenshuai2144 force-pushed the newEditTable branch 3 times, most recently from 3c80f87 to 0309675 May 2, 2018

...col,
onCell: record => ({
record,
inputType: record.dataIndex === 'age' ? 'number' : 'text',

This comment has been minimized.

@yesmeck

yesmeck May 7, 2018

Member

col.dataIndex

@yesmeck yesmeck force-pushed the newEditTable branch from d34831d to 348b823 May 7, 2018

@yesmeck yesmeck merged commit d5c5219 into master May 7, 2018

6 checks passed

codecov/patch Coverage not affected when comparing 5e99a93...348b823
Details
codecov/project 86.47% remains the same compared to 5e99a93
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No new issues
Details

@yesmeck yesmeck deleted the newEditTable branch May 7, 2018

bors bot added a commit to mozilla/delivery-console that referenced this pull request May 10, 2018

Merge #158
158: Update dependency antd to v3.5.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.0` to `v3.5.1`



<details>
<summary>Release Notes</summary>

### [`v3.5.1`](https://github.com/ant-design/ant-design/releases/3.5.1)
[Compare Source](ant-design/ant-design@3.5.0...3.5.1)
- 🐞 Fixed broken style of Input.Group under Form. [#&#8203;10371](`ant-design/ant-design#10371)
- 🐞 Fixed overlay style of Select. [#&#8203;10383](`ant-design/ant-design#10383)
- 🐞 Remove focused style of Collapse.
- 🐞 Remove unnecessary `z-index` of Input.Group and Checkbox. [#&#8203;9840](`ant-design/ant-design#9840) [#&#8203;10385](`ant-design/ant-design#10385)
- 🐞 Fixed that monospaced font family can't be bold.
- Table
  - 💄 Rewrited the editable table demo. [#&#8203;10119](`ant-design/ant-design#10119)
  - 🐞 Fixed that table column overlay each other. [#&#8203;9822](`ant-design/ant-design#9822)
- TypeScript
  - 🐞 Fixed Breadcrumb.Item type. [#&#8203;10372](`ant-design/ant-design#10372) [@&#8203;karol-majewski]
  - 🐞 Fixed Table `rowSelection` type。[#&#8203;10374](`ant-design/ant-design#10374)


---


- 🐞 修复 Input.Group 在 Form 下样式错位的问题。[#&#8203;10371](`ant-design/ant-design#10371)
- 🐞 修复 Select 箭头和内容重叠的问题。[#&#8203;10383](`ant-design/ant-design#10383)
- 🐞 移除 Collapse 点击时的 focus 样式。
- 🐞 移除 Input.Group 和 Checkbox 不必要的 `z-index`。[#&#8203;9840](`ant-design/ant-design#9840) [#&#8203;10385](`ant-design/ant-design#10385)
- 🐞 修复一个数字等宽字体没有加粗的问题。
- Table
  - 💄 重写了可编辑表格的演示。[#&#8203;10119](`ant-design/ant-design#10119)
  - 🐞 修复一个表格列内容互相重叠的问题。[#&#8203;9822](`ant-design/ant-design#9822)
- TypeScript
  - 🐞 调整 Breadcrumb.Item 的类型。[#&#8203;10372](`ant-design/ant-design#10372) [@&#8203;karol-majewski]
  - 🐞 修复 Table 的 `rowSelection` 的类型。[#&#8203;10374](`ant-design/ant-design#10374)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment