New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong List property (#10123) #10128

merged 1 commit into from Apr 17, 2018


None yet
3 participants

slonoed commented Apr 17, 2018

This diff excludes locale from rest variable to
avoid passing to div.

Close #10123

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
Fix wrong List property (#10123)
This diff excludes `locale` from `rest` variable to
avoid passing to div.

Close #10123

@slonoed slonoed force-pushed the slonoed:fix-list-property branch from 0012930 to a28e8b7 Apr 17, 2018


This comment has been minimized.

ant-design-bot commented Apr 17, 2018

Deploy preview for ant-design ready!

Built with commit 0012930


This comment has been minimized.

ant-design-bot commented Apr 17, 2018

Deploy preview for ant-design ready!

Built with commit a28e8b7


This comment has been minimized.

codecov bot commented Apr 17, 2018

Codecov Report

Merging #10128 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10128   +/-   ##
  Coverage   86.29%   86.29%           
  Files         197      197           
  Lines        4742     4742           
  Branches     1321     1321           
  Hits         4092     4092           
  Misses        647      647           
  Partials        3        3
Impacted Files Coverage Δ
components/list/index.tsx 96.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad72111...a28e8b7. Read the comment docs.

@afc163 afc163 merged commit c0e60f8 into ant-design:master Apr 17, 2018

5 checks passed

codecov/patch 100% of diff hit (target 86.29%)
codecov/project 86.29% (+0%) compared to ad72111
continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!
security/snyk No dependency changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment