Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upList integrate pagination functional fixed: #9303 #10135
Conversation
This comment has been minimized.
This comment has been minimized.
ant-design-bot
commented
Apr 18, 2018
|
Deploy preview for ant-design ready! Built with commit 1663bf5 |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 18, 2018
•
Codecov Report
@@ Coverage Diff @@
## feature-3.5.0 #10135 +/- ##
=================================================
+ Coverage 86.28% 86.34% +0.05%
=================================================
Files 197 197
Lines 4741 4761 +20
Branches 1322 1326 +4
=================================================
+ Hits 4091 4111 +20
Misses 647 647
Partials 3 3
Continue to review full report at Codecov.
|
nikogu
requested a review
from
yesmeck
Apr 19, 2018
| ); | ||
| } | ||
| } | ||
This comment has been minimized.
This comment has been minimized.
nikogu
Apr 19, 2018
Contributor
截取数据的逻辑是，如果当前获取的数据数目大于当前所需要截取的数量，说明需要进行数据截取，反之则不截取（出现在异步加载情况的数据的情况下）
| @@ -163,24 +195,54 @@ export default class List extends React.Component<ListProps> { | ||
| [`${prefixCls}-something-after-last-item`]: this.isSomethingAfterLastItem(), | ||
| }); | ||
| this.defaultPaginationProps.total = dataSource.length; | ||
| this.defaultPaginationProps.current = paginationCurrent; |
This comment has been minimized.
This comment has been minimized.
| ); | ||
| if (paginationProps.current > largestPage) { | ||
| paginationProps.current = largestPage; | ||
| } |
This comment has been minimized.
This comment has been minimized.
nikogu
requested a review
from
afc163
Apr 19, 2018
nikogu
merged commit d50ec43
into
feature-3.5.0
Apr 20, 2018
6 checks passed
codecov/patch
100% of diff hit (target 86.28%)
Details
codecov/project
86.34% (+0.05%) compared to 04a5cc2
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
deploy/netlify
Deploy preview ready!
Details
security/snyk
No dependency changes
Details
nikogu
deleted the
List-integrate-Pagination-functional
branch
Apr 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nikogu commentedApr 18, 2018
#9303