Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix menu item's clickable region in dark theme #10187
Conversation
dgeibi
added some commits
Apr 22, 2018
This comment has been minimized.
This comment has been minimized.
ant-design-bot
commented
Apr 22, 2018
|
Deploy preview for ant-design ready! Built with commit af34a21 |
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Apr 22, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #10187 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 197 197
Lines 4745 4745
Branches 1324 1324
=======================================
Hits 4097 4097
Misses 645 645
Partials 3 3Continue to review full report at Codecov.
|
afc163
merged commit bb720aa
into
ant-design:master
Apr 22, 2018
5 checks passed
codecov/patch
Coverage not affected when comparing 8ab4aeb...af34a21
Details
codecov/project
86.34% remains the same compared to 8ab4aeb
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
deploy/netlify
Deploy preview ready!
Details
security/snyk
No dependency changes
Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
dgeibi commentedApr 22, 2018
#9666 修过，但没有调整 dark theme :(
current
https://codesandbox.io/s/jjx5on3njw
with patch
https://codesandbox.io/s/0ollrv2nnn