New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu item's clickable region in dark theme #10187

Merged
merged 2 commits into from Apr 22, 2018

Conversation

Projects
None yet
3 participants
@dgeibi
Contributor

dgeibi commented Apr 22, 2018

#9666 修过,但没有调整 dark theme :(

current

notfixed

https://codesandbox.io/s/jjx5on3njw

with patch

fixed

https://codesandbox.io/s/0ollrv2nnn

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Apr 22, 2018

Deploy preview for ant-design ready!

Built with commit af34a21

https://deploy-preview-10187--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Apr 22, 2018

Codecov Report

Merging #10187 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10187   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files         197      197           
  Lines        4745     4745           
  Branches     1324     1324           
=======================================
  Hits         4097     4097           
  Misses        645      645           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ab4aeb...af34a21. Read the comment docs.

@afc163 afc163 merged commit bb720aa into ant-design:master Apr 22, 2018

5 checks passed

codecov/patch Coverage not affected when comparing 8ab4aeb...af34a21
Details
codecov/project 86.34% remains the same compared to 8ab4aeb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment