add `lib/**/style/*` as sideEffects #10217
Merged
Conversation
Deploy preview for ant-design ready! Built with commit 87e40d4 |
Codecov Report
@@ Coverage Diff @@
## master #10217 +/- ##
=======================================
Coverage 86.34% 86.34%
=======================================
Files 197 197
Lines 4745 4745
Branches 1324 1324
=======================================
Hits 4097 4097
Misses 645 645
Partials 3 3 Continue to review full report at Codecov.
|
it's very helpful to me! |
Closed
@yutingzhao1991 babel-plugin-import 改为
确实能解决,3.4.4还会不会改了这个问题? |
@mcdyzg 会改,不过 webpack 3 以上推荐用 es 目录,可以有 tree shaking. |
@yesmeck 已经使用babel-plugin-import按需加载单独组件了,换成 |
会 |
afc163
added a commit
that referenced
this pull request
Apr 28, 2018
afc163
added a commit
that referenced
this pull request
Apr 28, 2018
* add `lib/**/style/*` as sideEffects (#10217) * Fix upload onChange arg type when beforeUpload return false, close #10293 * 3.4.4 * Fix ts error temporarily, DefinitelyTyped/DefinitelyTyped#25342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :
fix #10190