Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add `lib/**/style/*` as sideEffects #10217

Merged
merged 1 commit into from Apr 24, 2018
Merged

add `lib/**/style/*` as sideEffects #10217

merged 1 commit into from Apr 24, 2018

Conversation

@whtsky
Copy link
Contributor

@whtsky whtsky commented Apr 24, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

fix #10190

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Apr 24, 2018

Deploy preview for ant-design ready!

Built with commit 87e40d4

https://deploy-preview-10217--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Apr 24, 2018

Codecov Report

Merging #10217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10217   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files         197      197           
  Lines        4745     4745           
  Branches     1324     1324           
=======================================
  Hits         4097     4097           
  Misses        645      645           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bc28ac...87e40d4. Read the comment docs.

@Kingwl
Copy link

@Kingwl Kingwl commented Apr 24, 2018

it's very helpful to me!

@yesmeck yesmeck merged commit 262ed8e into ant-design:master Apr 24, 2018
5 checks passed
5 checks passed
codecov/patch Coverage not affected when comparing 4bc28ac...87e40d4
Details
codecov/project 86.34% remains the same compared to 4bc28ac
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No new issues
Details
@whtsky whtsky deleted the whtsky:patch-1 branch Apr 24, 2018
@yutingzhao1991 yutingzhao1991 mentioned this pull request Apr 24, 2018
@mcdyzg
Copy link

@mcdyzg mcdyzg commented Apr 26, 2018

@yutingzhao1991 babel-plugin-import 改为

['import', { libraryName: 'antd', libraryDirectory: 'es', style: true }]

确实能解决,3.4.4还会不会改了这个问题?
还是说以后都指定libraryDirectory: 'es'了。

@yesmeck
Copy link
Member

@yesmeck yesmeck commented Apr 26, 2018

@mcdyzg 会改,不过 webpack 3 以上推荐用 es 目录,可以有 tree shaking.

@mcdyzg
Copy link

@mcdyzg mcdyzg commented Apr 26, 2018

@yesmeck 已经使用babel-plugin-import按需加载单独组件了,换成libraryDirectory: 'es'还会再对子组件tree-shaking一次吗?

@yesmeck
Copy link
Member

@yesmeck yesmeck commented Apr 26, 2018

afc163 added a commit that referenced this pull request Apr 28, 2018
afc163 added a commit that referenced this pull request Apr 28, 2018
* add `lib/**/style/*` as sideEffects (#10217)

* Fix upload onChange arg type when beforeUpload return false, close #10293

* 3.4.4

* Fix ts error temporarily, DefinitelyTyped/DefinitelyTyped#25342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants