New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): use React.HTMLProps for button's props #10229

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
3 participants
@whtsky
Contributor

whtsky commented Apr 24, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

The old props of Button component lacks a lot of prop, like onMouseOver etc.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed. ( Not possible since it's a typing fix and test are written in JavaScript )
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Apr 24, 2018

Deploy preview for ant-design ready!

Built with commit 93d54e4

https://deploy-preview-10229--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Apr 24, 2018

Codecov Report

Merging #10229 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10229   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files         197      197           
  Lines        4745     4745           
  Branches     1324     1324           
=======================================
  Hits         4097     4097           
  Misses        645      645           
  Partials        3        3
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100% <ø> (ø) ⬆️
components/transfer/operation.tsx 62.5% <ø> (ø) ⬆️
components/button/button.tsx 95% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 262ed8e...93d54e4. Read the comment docs.

@yesmeck yesmeck referenced this pull request May 4, 2018

Closed

fix:ButtonProps has no onSubmit #10361

0 of 10 tasks complete

@yesmeck yesmeck merged commit 6019245 into ant-design:master May 4, 2018

5 checks passed

codecov/patch 100% of diff hit (target 86.34%)
Details
codecov/project 86.34% (+0%) compared to 262ed8e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details

@whtsky whtsky deleted the whtsky:fix-button-typing branch May 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment