New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): fix typing for `Form.onValuesChange` #10231

Merged
merged 1 commit into from Apr 24, 2018

Conversation

Projects
None yet
4 participants
@whtsky
Contributor

whtsky commented Apr 24, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

close #10222

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Apr 24, 2018

Deploy preview for ant-design ready!

Built with commit e120a0e

https://deploy-preview-10231--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Apr 24, 2018

Codecov Report

Merging #10231 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10231   +/-   ##
=======================================
  Coverage   86.34%   86.34%           
=======================================
  Files         197      197           
  Lines        4745     4745           
  Branches     1324     1324           
=======================================
  Hits         4097     4097           
  Misses        645      645           
  Partials        3        3
Impacted Files Coverage Δ
components/form/Form.tsx 95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a268dc8...e120a0e. Read the comment docs.

@afc163 afc163 merged commit 4ea20e6 into ant-design:master Apr 24, 2018

5 checks passed

codecov/patch Coverage not affected when comparing a268dc8...e120a0e
Details
codecov/project 86.34% remains the same compared to a268dc8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details

@whtsky whtsky deleted the whtsky:fix/form_type branch Apr 24, 2018

@HHHui

This comment has been minimized.

HHHui commented Apr 25, 2018

@whtsky 我又看了一下,发现onFieldsChange也是同样的问题.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment