Fix: Form tsd #10324
Merged
Fix: Form tsd #10324
Conversation
|
Deploy preview for ant-design ready! Built with commit 631ea97 |
components/_util/type.ts
Outdated
| { [P in U]: never } & { [x: string]: never })[T]; | ||
| export type Omit<T, K extends keyof T> = Pick<T, Diff<keyof T, K>>; | ||
| // https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#predefined-conditional-types | ||
| export type Omit<T, K> = Pick<T, Exclude<keyof T, K>>; |
yesmeck
May 2, 2018
Member
2.8 才引入的特性，所以没用。
2.8 才引入的特性，所以没用。
paranoidjk
May 2, 2018
Author
Contributor
这个可改可不改，不影响运行时
这个可改可不改，不影响运行时
paranoidjk
May 2, 2018
Author
Contributor
主要是修类型定义的问题。snapshot 挂了是什么模块更新搞挂了？
主要是修类型定义的问题。snapshot 挂了是什么模块更新搞挂了？
yesmeck
May 2, 2018
Member
rebase 下吧。
还是不要改了，少点 surprise.
rebase 下吧。
还是不要改了，少点 surprise.
paranoidjk
May 2, 2018
Author
Contributor
done
done
Codecov Report
@@ Coverage Diff @@
## master #10324 +/- ##
=======================================
Coverage 86.45% 86.45%
=======================================
Files 196 196
Lines 4777 4777
Branches 1334 1334
=======================================
Hits 4130 4130
Misses 644 644
Partials 3 3
Continue to review full report at Codecov.
|
|
@paranoidjk Can you fix the problem of @Form.create()? proposed to modify the form.d.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Ref: https://github.com/react-component/form/blob/master/src/createBaseForm.js#L499
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :