New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Form tsd #10324

Merged
merged 4 commits into from May 2, 2018

Conversation

Projects
None yet
4 participants
@paranoidjk
Member

paranoidjk commented May 2, 2018

Ref: https://github.com/react-component/form/blob/master/src/createBaseForm.js#L499

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@paranoidjk paranoidjk changed the title from Form tsd to WIP Form tsd May 2, 2018

@ant-design-bot

This comment has been minimized.

ant-design-bot commented May 2, 2018

Deploy preview for ant-design ready!

Built with commit 631ea97

https://deploy-preview-10324--ant-design.netlify.com

@paranoidjk paranoidjk changed the title from WIP Form tsd to Fix: Form tsd May 2, 2018

@paranoidjk paranoidjk force-pushed the form-tsd branch from 5d1555d to 487cb73 May 2, 2018

{ [P in U]: never } & { [x: string]: never })[T];
export type Omit<T, K extends keyof T> = Pick<T, Diff<keyof T, K>>;
// https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#predefined-conditional-types
export type Omit<T, K> = Pick<T, Exclude<keyof T, K>>;

This comment has been minimized.

@yesmeck

yesmeck May 2, 2018

Member

2.8 才引入的特性,所以没用。

This comment has been minimized.

@paranoidjk

paranoidjk May 2, 2018

Member

这个可改可不改,不影响运行时

This comment has been minimized.

@paranoidjk

paranoidjk May 2, 2018

Member

主要是修类型定义的问题。snapshot 挂了是什么模块更新搞挂了?

This comment has been minimized.

@yesmeck

yesmeck May 2, 2018

Member

rebase 下吧。

还是不要改了,少点 surprise.

This comment has been minimized.

@paranoidjk

@paranoidjk paranoidjk force-pushed the form-tsd branch from 487cb73 to 631ea97 May 2, 2018

@codecov

This comment has been minimized.

codecov bot commented May 2, 2018

Codecov Report

Merging #10324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10324   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files         196      196           
  Lines        4777     4777           
  Branches     1334     1334           
=======================================
  Hits         4130     4130           
  Misses        644      644           
  Partials        3        3
Impacted Files Coverage Δ
components/form/Form.tsx 95% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e3384...631ea97. Read the comment docs.

@yesmeck yesmeck merged commit b6f8ab8 into master May 2, 2018

6 checks passed

codecov/patch Coverage not affected when comparing 56e3384...631ea97
Details
codecov/project 86.45% remains the same compared to 56e3384
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details

@yesmeck yesmeck deleted the form-tsd branch May 2, 2018

@icodytan

This comment has been minimized.

icodytan commented May 9, 2018

@paranoidjk Can you fix the problem of @Form.create()? proposed to modify the form.d.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment