Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix: Form tsd #10324
Conversation
paranoidjk
assigned
yesmeck
May 2, 2018
paranoidjk
changed the title from
Form tsd
to
WIP Form tsd
May 2, 2018
This comment has been minimized.
This comment has been minimized.
ant-design-bot
commented
May 2, 2018
•
|
Deploy preview for ant-design ready! Built with commit 631ea97 |
paranoidjk
changed the title from
WIP Form tsd
to
Fix: Form tsd
May 2, 2018
paranoidjk
force-pushed the
form-tsd
branch
from
5d1555d
to
487cb73
May 2, 2018
components/_util/type.ts
Outdated
| { [P in U]: never } & { [x: string]: never })[T]; | ||
| export type Omit<T, K extends keyof T> = Pick<T, Diff<keyof T, K>>; | ||
| // https://www.typescriptlang.org/docs/handbook/release-notes/typescript-2-8.html#predefined-conditional-types | ||
| export type Omit<T, K> = Pick<T, Exclude<keyof T, K>>; |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
paranoidjk
added some commits
May 2, 2018
paranoidjk
force-pushed the
form-tsd
branch
from
487cb73
to
631ea97
May 2, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
May 2, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #10324 +/- ##
=======================================
Coverage 86.45% 86.45%
=======================================
Files 196 196
Lines 4777 4777
Branches 1334 1334
=======================================
Hits 4130 4130
Misses 644 644
Partials 3 3
Continue to review full report at Codecov.
|
yesmeck
merged commit b6f8ab8
into
master
May 2, 2018
6 checks passed
codecov/patch
Coverage not affected when comparing 56e3384...631ea97
Details
codecov/project
86.45% remains the same compared to 56e3384
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
continuous-integration/travis-ci/push
The Travis CI build passed
Details
deploy/netlify
Deploy preview ready!
Details
security/snyk
No dependency changes
Details
yesmeck
deleted the
form-tsd
branch
May 2, 2018
This comment has been minimized.
This comment has been minimized.
icodytan
commented
May 9, 2018
|
@paranoidjk Can you fix the problem of @Form.create()? proposed to modify the form.d.ts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
paranoidjk commentedMay 2, 2018
•
edited
Ref: https://github.com/react-component/form/blob/master/src/createBaseForm.js#L499
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :