New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #10289 and #10209: lost of user selection on table data updates #10332

Merged
merged 2 commits into from May 4, 2018

Conversation

Projects
None yet
3 participants
@chrvadala
Contributor

chrvadala commented May 2, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented May 2, 2018

Deploy preview for ant-design ready!

Built with commit 8c76410

https://deploy-preview-10332--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented May 2, 2018

Codecov Report

Merging #10332 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10332   +/-   ##
=======================================
  Coverage   86.45%   86.45%           
=======================================
  Files         196      196           
  Lines        4777     4777           
  Branches     1334     1334           
=======================================
  Hits         4130     4130           
  Misses        644      644           
  Partials        3        3
Impacted Files Coverage Δ
components/table/filterDropdown.tsx 96.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f8ab8...8c76410. Read the comment docs.

* Fixes https://github.com/ant-design/ant-design/issues/10289 and
* https://github.com/ant-design/ant-design/issues/10209
*/
if ('selectedKeys' in nextProps && !this.state.visible) {

This comment has been minimized.

@yesmeck

yesmeck May 2, 2018

Member

I think we also need to compare this.props.selectedKeys and nextProps.selectKeys are not shallow equal so that selectedKeys can be controlled from outside when the dropdown is visible.

This comment has been minimized.

@chrvadala

chrvadala May 2, 2018

Contributor

In that case I think that is no more required the visibility check, but the shallow compare should fix the issue as well

@yesmeck yesmeck merged commit f4b8a58 into ant-design:master May 4, 2018

5 checks passed

codecov/patch 100% of diff hit (target 86.45%)
Details
codecov/project 86.45% (+0%) compared to b6f8ab8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No new issues
Details

@yesmeck yesmeck referenced this pull request May 4, 2018

Closed

Table filters do not persit on rerender #10209

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment