New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use exact type for <Breadcrumb.Item /> #10372

Merged
merged 1 commit into from May 4, 2018

Conversation

Projects
None yet
3 participants
@karol-majewski
Contributor

karol-majewski commented May 4, 2018

Using any as the type for <Breadcrumb.Item /> component breaks the build for TSLint users having the no-unsafe-any rule enabled.

Said rule marks all instances where entites of unknown shape are consumed, putting the consumer at risk of using a member that doesn't exist. In this situation, the type of Item is well defined (exactly the same as BreadcrumbItem), so there is no reason not to leverage it.

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.
Use exact type for Breadcrumb.Item
Using "any" breaks the build for TSLint users having the "no-unsafe-any" rule enabled.

See https://palantir.github.io/tslint/rules/no-unsafe-any/
@ant-design-bot

This comment has been minimized.

ant-design-bot commented May 4, 2018

Deploy preview for ant-design ready!

Built with commit 66260e4

https://deploy-preview-10372--ant-design.netlify.com

@afc163 afc163 merged commit 1479726 into ant-design:master May 4, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details

@karol-majewski karol-majewski deleted the karol-majewski:breadcrumb-item-type-definition branch May 4, 2018

@codecov

This comment has been minimized.

codecov bot commented May 4, 2018

Codecov Report

Merging #10372 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10372   +/-   ##
=======================================
  Coverage   86.46%   86.46%           
=======================================
  Files         196      196           
  Lines        4788     4788           
  Branches     1340     1340           
=======================================
  Hits         4140     4140           
  Misses        645      645           
  Partials        3        3
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 45.23% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9368e2d...66260e4. Read the comment docs.

bors bot added a commit to mozilla/delivery-console that referenced this pull request May 10, 2018

Merge #158
158: Update dependency antd to v3.5.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.0` to `v3.5.1`



<details>
<summary>Release Notes</summary>

### [`v3.5.1`](https://github.com/ant-design/ant-design/releases/3.5.1)
[Compare Source](ant-design/ant-design@3.5.0...3.5.1)
- 🐞 Fixed broken style of Input.Group under Form. [#&#8203;10371](`ant-design/ant-design#10371)
- 🐞 Fixed overlay style of Select. [#&#8203;10383](`ant-design/ant-design#10383)
- 🐞 Remove focused style of Collapse.
- 🐞 Remove unnecessary `z-index` of Input.Group and Checkbox. [#&#8203;9840](`ant-design/ant-design#9840) [#&#8203;10385](`ant-design/ant-design#10385)
- 🐞 Fixed that monospaced font family can't be bold.
- Table
  - 💄 Rewrited the editable table demo. [#&#8203;10119](`ant-design/ant-design#10119)
  - 🐞 Fixed that table column overlay each other. [#&#8203;9822](`ant-design/ant-design#9822)
- TypeScript
  - 🐞 Fixed Breadcrumb.Item type. [#&#8203;10372](`ant-design/ant-design#10372) [@&#8203;karol-majewski]
  - 🐞 Fixed Table `rowSelection` type。[#&#8203;10374](`ant-design/ant-design#10374)


---


- 🐞 修复 Input.Group 在 Form 下样式错位的问题。[#&#8203;10371](`ant-design/ant-design#10371)
- 🐞 修复 Select 箭头和内容重叠的问题。[#&#8203;10383](`ant-design/ant-design#10383)
- 🐞 移除 Collapse 点击时的 focus 样式。
- 🐞 移除 Input.Group 和 Checkbox 不必要的 `z-index`。[#&#8203;9840](`ant-design/ant-design#9840) [#&#8203;10385](`ant-design/ant-design#10385)
- 🐞 修复一个数字等宽字体没有加粗的问题。
- Table
  - 💄 重写了可编辑表格的演示。[#&#8203;10119](`ant-design/ant-design#10119)
  - 🐞 修复一个表格列内容互相重叠的问题。[#&#8203;9822](`ant-design/ant-design#9822)
- TypeScript
  - 🐞 调整 Breadcrumb.Item 的类型。[#&#8203;10372](`ant-design/ant-design#10372) [@&#8203;karol-majewski]
  - 🐞 修复 Table 的 `rowSelection` 的类型。[#&#8203;10374](`ant-design/ant-design#10374)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment