Allow to use any CSS units for layout width #10479
Merged
Conversation
|
Deploy preview for ant-design ready! Built with commit b180cb6 |
Codecov Report
@@ Coverage Diff @@
## master #10479 +/- ##
==========================================
- Coverage 86.48% 86.48% -0.01%
==========================================
Files 196 196
Lines 4795 4794 -1
Branches 1339 1338 -1
==========================================
- Hits 4147 4146 -1
Misses 645 645
Partials 3 3
Continue to review full report at Codecov.
|
|
Could you add a test case? |
afc163
merged commit 71abb96
into
ant-design:master
5 checks passed
5 checks passed
codecov/project
Absolute coverage decreased by -<.01% but relative coverage increased by +13.51% compared to dd7fb9d
Details
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
May 14, 2018
160: Update dependency antd to v3.5.2 r=rehandalal a=renovate[bot] This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.1` to `v3.5.2` <details> <summary>Release Notes</summary> ### [`v3.5.2`](https://github.com/ant-design/ant-design/releases/3.5.2) [Compare Source](ant-design/ant-design@3.5.1...3.5.2) -🐞 Fixed `Cascader` displayRender z-index issue. [#​10433](`ant-design/ant-design#10433) -🐞 Fixed `Button` Types of property 'ref' are incompatible. [#​10405](`ant-design/ant-design#10405) -🐞 Fixed `Table` filter doesn't work on checkbox click. [#​10452](`ant-design/ant-design#10452) -🐞 Fixed the height of `Form` item when checks position is dithered. [#​10445](`ant-design/ant-design#10445) -🌟 Allow to use any CSS units for `Layout` width. [#​10479](`ant-design/ant-design#10479) --- -🐞 修复 `Cascader` 的 displayRender 问题。[#​10433](`ant-design/ant-design#10433) -🐞 修复 `Button` ref 不兼容问题。[#​10405](`ant-design/ant-design#10405) -🐞 修复 `Table` 过滤器在复选框上不起作用。[#​10452](`ant-design/ant-design#10452) -🐞 修复 `Form` 表单项校验位置高度时出现抖动问题。[#​10445](`ant-design/ant-design#10445) -🌟 设置 `Layout` 宽度时，允许使用任何的 CSS 单位。 [#​10479](`ant-design/ant-design#10479) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
|
I appreciated your time and effort! It helps me a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
From docs we can see that
widthof layout can be number or string. For me it means I can use50%,20emand so on. Currently, only pixels are supported.This PR is going to fix it. It will allow to use any CSS units for layout width.
Resolves #9719💯