New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use any CSS units for layout width #10479

Merged
merged 5 commits into from May 11, 2018

Conversation

Projects
None yet
3 participants
@ApacheEx
Contributor

ApacheEx commented May 11, 2018

馃憢
From docs we can see that width of layout can be number or string. For me it means I can use 50%, 20em and so on. Currently, only pixels are supported.

This PR is going to fix it. It will allow to use any CSS units for layout width.

Resolves #9719 馃挴

@ant-design-bot

This comment has been minimized.

ant-design-bot commented May 11, 2018

Deploy preview for ant-design ready!

Built with commit b180cb6

https://deploy-preview-10479--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented May 11, 2018

Codecov Report

Merging #10479 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10479      +/-   ##
==========================================
- Coverage   86.48%   86.48%   -0.01%     
==========================================
  Files         196      196              
  Lines        4795     4794       -1     
  Branches     1339     1338       -1     
==========================================
- Hits         4147     4146       -1     
  Misses        645      645              
  Partials        3        3
Impacted Files Coverage 螖
components/layout/Sider.tsx 76.54% <100%> (-0.29%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update dd7fb9d...b180cb6. Read the comment docs.

@afc163

This comment has been minimized.

Member

afc163 commented May 11, 2018

Could you add a test case?

ApacheEx added some commits May 11, 2018

@afc163 afc163 merged commit 71abb96 into ant-design:master May 11, 2018

5 checks passed

codecov/patch 100% of diff hit (target 86.48%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +13.51% compared to dd7fb9d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details

bors bot added a commit to mozilla/delivery-console that referenced this pull request May 14, 2018

Merge #160
160: Update dependency antd to v3.5.2 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.1` to `v3.5.2`



<details>
<summary>Release Notes</summary>

### [`v3.5.2`](https://github.com/ant-design/ant-design/releases/3.5.2)
[Compare Source](ant-design/ant-design@3.5.1...3.5.2)
- 馃悶 Fixed `Cascader` displayRender z-index issue. [#&#8203;10433](`ant-design/ant-design#10433)
- 馃悶 Fixed `Button` Types of property 'ref' are incompatible. [#&#8203;10405](`ant-design/ant-design#10405)
- 馃悶 Fixed `Table` filter doesn't work on checkbox click. [#&#8203;10452](`ant-design/ant-design#10452)
- 馃悶 Fixed the height of `Form` item when checks position is dithered. [#&#8203;10445](`ant-design/ant-design#10445)
- 馃専 Allow to use any CSS units for `Layout` width. [#&#8203;10479](`ant-design/ant-design#10479)


---


- 馃悶 淇 `Cascader` 鐨 displayRender 闂銆俒#&#8203;10433](`ant-design/ant-design#10433)
- 馃悶 淇 `Button` ref 涓嶅吋瀹归棶棰樸俒#&#8203;10405](`ant-design/ant-design#10405)
- 馃悶 淇 `Table` 杩囨护鍣ㄥ湪澶嶉夋涓婁笉璧蜂綔鐢ㄣ俒#&#8203;10452](`ant-design/ant-design#10452)
- 馃悶 淇 `Form` 琛ㄥ崟椤规牎楠屼綅缃珮搴︽椂鍑虹幇鎶栧姩闂銆俒#&#8203;10445](`ant-design/ant-design#10445)
- 馃専 璁剧疆 `Layout` 瀹藉害鏃讹紝鍏佽浣跨敤浠讳綍鐨 CSS 鍗曚綅銆 [#&#8203;10479](`ant-design/ant-design#10479)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment