fix Affix/index.tsx while offsetTop === 0 and offsetBottom is numberic #10566
Conversation
Fix: if offsetTop === 0, it will get undefined, if offsetBottom is type of number, offsetMode will be { top: false, ... }
Deploy preview for ant-design ready! Built with commit 1bb9481 |
Codecov Report
@@ Coverage Diff @@
## master #10566 +/- ##
=======================================
Coverage 86.4% 86.4%
=======================================
Files 196 196
Lines 4795 4795
Branches 1339 1339
=======================================
Hits 4143 4143
Misses 649 649
Partials 3 3
Continue to review full report at Codecov.
|
Could you add a test case for this? |
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
May 21, 2018
163: Update dependency antd to v3.5.3 r=rehandalal a=renovate[bot] This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.2` to `v3.5.3` <details> <summary>Release Notes</summary> ### [`v3.5.3`](https://github.com/ant-design/ant-design/releases/3.5.3) [Compare Source](ant-design/ant-design@3.5.2...3.5.3) -🐞 Fix `Affix` with offsetTop === 0, value becomes `undefined` problem [#​10566](`ant-design/ant-design#10566) -🐞 Fixed issue with shaded `Input.Group` component shadows[#​10230](`ant-design/ant-design#10230) -🐞 Fixed issue where the `Transfer` component checkbox event fired twice [#​10480](`ant-design/ant-design#10480) -💄 Unifying the name of the variable [12d3046](ant-design/ant-design@12d3046) -💄 Fine-tuned the style of `Dropdown` [8e2f72f](ant-design/ant-design@8e2f72f) -💄 The components of the Chinese document will now be demonstrated using Chinese language packages. [9b17a94](ant-design/ant-design@9b17a94) -💄 The main theme switch was changed to `antd-theme-generato`, thanks to the work of [@​mzohaibqc]. - TypeScript -🐞 Fixed an issue with the type of gutter attribute in `Row` [b7d508e](ant-design/ant-design@b7d508e) -💄 Improved the `Form` component type [#​10564](`ant-design/ant-design#10564) -💄 Improved the `Button` and `Tag` types[1ed9fed](ant-design/ant-design@1ed9fed) --- -🐞 修复了 `Affix` 当 `offsetTop === 0`, 值将变为 `undefined` 的问题 [#​10566](`ant-design/ant-design#10566) -🐞 修复了 `Menu` item 中的高亮链接颜色问题 [09d5e36](ant-design/ant-design@09d5e36) -🐞 修复了 `Input.Group` 组件阴影被遮盖的问题 [#​10230](`ant-design/ant-design#10230) -🐞 修复了 `Transfer` 组件 checkbox 事件触发两次的问题 [`#10480`](`ant-design/ant-design#10480) -💄 统一 less 的变量命名 [12d3046](ant-design/ant-design@12d3046) -💄 微调了 `Dropdown` 的样式 [8e2f72f](ant-design/ant-design@8e2f72f) -💄 现在中文文档的组件会用中文语言包进行演示。[9b17a94](ant-design/ant-design@9b17a94) -💄 主站主题切换 修改为 `antd-theme-generato` ,感谢 [@​mzohaibqc] 的工作. - TypeScript -🐞 修复了 `Row` 中 gutter 属性的类型问题 [b7d508e](ant-design/ant-design@b7d508e) -💄 改进了 `Form` 组件类型 [#​10564](`ant-design/ant-design#10564) -💄 改进了 `Button` 和 `Tag` 类型 [1ed9fed](ant-design/ant-design@1ed9fed) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix: if offsetTop === 0, it will get undefined, if offsetBottom is type of number, offsetMode will be { top: false, ... }
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master
, feature for latest active branchfeature-x.x
.npm run lint
and fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
elif isNewFeature :