Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add position config for List pagination #10581



Copy link

@zheeeng zheeeng commented May 19, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

Copy link

Deploy preview for ant-design ready!

Built with commit 473779d

Copy link
Contributor Author

zheeeng commented May 21, 2018

@afc163 Can we update the test snapshots by sync master to feature-3.6.0 branch? The dependency packages updated and caused the snapshot tests failing.

Copy link

afc163 commented May 21, 2018


@zheeeng zheeeng closed this May 21, 2018
@zheeeng zheeeng deleted the feature-List-pagination-position branch May 21, 2018 08:21
Copy link

afc163 commented May 21, 2018

You don't need to close PR, just rebase feature-3.6.0 and push force.

@zheeeng zheeeng restored the feature-List-pagination-position branch May 21, 2018 08:25
@zheeeng zheeeng reopened this May 21, 2018
Copy link
Contributor Author

zheeeng commented May 21, 2018

@afc163 I'm cleaning another same name branch zheeeng:feature-list-pagination-position which has a different capital letter with 'List'. And this branch is auto closed by GitHub. After pushing the branch zheeeng:feature-List-pagination-position, I can re-open this PR again. 😄

Copy link

codecov bot commented May 21, 2018

Codecov Report

Merging #10581 into feature-3.6.0 will decrease coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           feature-3.6.0   #10581      +/-   ##
- Coverage          86.51%   86.44%   -0.07%     
  Files                196      196              
  Lines               4798     4803       +5     
  Branches            1340     1344       +4     
+ Hits                4151     4152       +1     
- Misses               644      648       +4     
  Partials               3        3
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100% <ø> (ø) ⬆️
components/table/Table.tsx 93.44% <100%> (ø) ⬆️
components/list/index.tsx 97.46% <100%> (+0.09%) ⬆️
components/index.tsx 42.85% <0%> (-57.15%) ⬇️
components/affix/index.tsx 66.66% <0%> (ø) ⬆️
components/input/Input.tsx 96.72% <0%> (ø) ⬆️
components/button/button.tsx 94.93% <0%> (ø) ⬆️
components/grid/row.tsx 70.58% <0%> (ø) ⬆️
components/transfer/index.tsx 87.41% <0%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3545cc...473779d. Read the comment docs.

@afc163 afc163 merged commit 59fe98a into ant-design:feature-3.6.0 May 21, 2018
bors bot added a commit to mozilla/delivery-console that referenced this pull request Jun 4, 2018
177: Update dependency antd to v3.6.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd]( from `v3.5.4` to `v3.6.1`

<summary>Release Notes</summary>

### [`v3.6.1`](
[Compare Source](ant-design/ant-design@3.6.0...3.6.1)
* 🐞 修复一个 Typescript 的编译错误。


* 🐞 Fixing a Typescript compilation error.


### [`v3.6.0`](
[Compare Source](ant-design/ant-design@3.5.4...3.6.0)
* 🌟 `Form`'s error message now can be customized with ReactNode. [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` support customized configuration for position of pagination. [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` now can be configured with `light` or `dark` theme. [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 Ant Design official site now supports offline mode. [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` adding `style` and `operationStyle` props for further customization. [@&#8203;eduludi]
* 🌟 `Message` adds a promisfied interface to handle callback. [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 Fix compilation issue with typescript@&#8203;v2.9.1 . [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 Fix a bug in `Menu` where outer menu item not highlighting while inner item is selected. [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 Affix `offsetBottom` not working. [#&#8203;10674](`ant-design/ant-design#10674)


* 🌟 `Form` 表单错误信息展示支持传入 ReactNode。 [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` 组件支持指定分页器的位置。 [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` 支持 dark/light 主题定制。 [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 支持 Ant Design 站点的离线模式。 [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` 新增 `style` 以及 `operationStyle` 属性配置样式。 [@&#8203;eduludi]
* 🌟 `Message` 增加 promise 化的回调接口。 [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 修复编译时 typescript v2.9.1兼容性问题。 [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 修复 `Menu` 嵌套超过两层时选中最里层后对应最外层没有亮起问题。 [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 修复 `Affix` 组件 offsetBottom 无效问题。 [#&#8203;10674](`ant-design/ant-design#10674)




This PR has been generated by [Renovate Bot](

Co-authored-by: Renovate Bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants