New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AutoComplete): add missing backfill prop in type #10909

merged 1 commit into from Jun 15, 2018


None yet
3 participants

zhanba commented Jun 14, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • [*] Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • [*] Make sure that you follow antd's code convention.
  • [*] Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • [*] Rebase before creating a PR to keep commit history clear.
  • [*] Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • [*] Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

This comment has been minimized.

ant-design-bot commented Jun 14, 2018

Deploy preview for ant-design ready!

Built with commit 0a52984


This comment has been minimized.

codecov bot commented Jun 14, 2018

Codecov Report

Merging #10909 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10909   +/-   ##
  Coverage   91.59%   91.59%           
  Files         194      194           
  Lines        4769     4769           
  Branches     1329     1329           
  Hits         4368     4368           
  Misses        397      397           
  Partials        4        4
Impacted Files Coverage Δ
components/auto-complete/index.tsx 87.17% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 980e2b1...0a52984. Read the comment docs.

@afc163 afc163 merged commit a5ff8e5 into ant-design:master Jun 15, 2018

6 checks passed

WIP ready for review
codecov/patch Coverage not affected when comparing 980e2b1...0a52984
codecov/project 91.59% remains the same compared to 980e2b1
continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!
security/snyk - package.json No dependency changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment