New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(upload): preview can't show image when the image file use uppercase extension. #10928

Merged
merged 1 commit into from Jun 15, 2018

Conversation

Projects
None yet
3 participants
@sliwey
Contributor

sliwey commented Jun 15, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Upload preview can't show image when the image file use uppercase extension, like .JPG
This pr fix it, and remove unnecessary escape character in function extname.

fix: upload preview can't show image when the image file use uppercas…
…e extension

	1.fix: upload preview can't show image when the image file use uppercase extension.
	2.improve: remove unnecessary escape character.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jun 15, 2018

Deploy preview for ant-design ready!

Built with commit f614668

https://deploy-preview-10928--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Jun 15, 2018

Codecov Report

Merging #10928 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10928   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         194      194           
  Lines        4769     4769           
  Branches     1329     1329           
=======================================
  Hits         4368     4368           
  Misses        397      397           
  Partials        4        4
Impacted Files Coverage Δ
components/upload/UploadList.tsx 88.77% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5ff8e5...f614668. Read the comment docs.

@afc163 afc163 merged commit 450a497 into ant-design:master Jun 15, 2018

6 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 91.59%)
Details
codecov/project 91.59% (+0%) compared to a5ff8e5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json No dependency changes
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment