New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Popconfirm support customize icon #11191

Merged
merged 1 commit into from Jul 16, 2018

Conversation

Projects
None yet
4 participants
@nuintun
Contributor

nuintun commented Jul 6, 2018

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
nuintun

@nuintun nuintun referenced this pull request Jul 6, 2018

Closed

Popconfirm support customize icon #11127

4 of 4 tasks complete
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jul 6, 2018

Deploy preview for ant-design ready!

Built with commit e75e051

https://deploy-preview-11191--ant-design.netlify.com

@afc163 afc163 closed this Jul 15, 2018

@nuintun nuintun referenced this pull request Jul 16, 2018

Closed

Popconfirm support set custom icon? #11124

1 of 1 task complete

@yesmeck yesmeck changed the base branch from feature-3.7.0 to feature-3.8.0 Jul 16, 2018

@yesmeck yesmeck reopened this Jul 16, 2018

@codecov

This comment has been minimized.

codecov bot commented Jul 16, 2018

Codecov Report

Merging #11191 into feature-3.8.0 will increase coverage by 0.31%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                @@
##           feature-3.8.0   #11191      +/-   ##
=================================================
+ Coverage          91.76%   92.07%   +0.31%     
=================================================
  Files                199      199              
  Lines               5000     5289     +289     
  Branches            1401     1564     +163     
=================================================
+ Hits                4588     4870     +282     
- Misses               407      414       +7     
  Partials               5        5
Impacted Files Coverage Δ
components/popconfirm/index.tsx 100% <100%> (ø) ⬆️
components/tree/Tree.tsx 100% <0%> (ø) ⬆️
components/date-picker/RangePicker.tsx 96.22% <0%> (+0.48%) ⬆️
components/table/Table.tsx 94.77% <0%> (+1.32%) ⬆️
components/layout/Sider.tsx 90.32% <0%> (+1.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6872131...e75e051. Read the comment docs.

@afc163 afc163 merged commit 8496e8f into ant-design:feature-3.8.0 Jul 16, 2018

6 checks passed

WIP ready for review
Details
codecov/patch 100% of diff hit (target 91.76%)
Details
codecov/project 92.07% (+0.31%) compared to 6872131
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment