New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix content without vertical alignment icon when using vertical label mode; And description text-align: center; #11426

Merged
merged 4 commits into from Jul 27, 2018

Conversation

Projects
None yet
4 participants
@yoyo837
Contributor

yoyo837 commented Jul 24, 2018

Fix content without vertical alignment icon when using vertical label mode; And description text-align: center;

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
Fix content without vertical alignment icon when using vertical label…
… mode; And description text-align: center;

@yoyo837 yoyo837 changed the title from Fix content without vertical alignment icon when using vertical labe… to Fix content without vertical alignment icon when using vertical label mode; And description text-align: center; Jul 24, 2018

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jul 24, 2018

Deploy preview for ant-design ready!

Built with commit 73271a0

https://deploy-preview-11426--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Jul 24, 2018

Codecov Report

Merging #11426 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #11426   +/-   ##
=======================================
  Coverage   91.83%   91.83%           
=======================================
  Files         199      199           
  Lines        5024     5024           
  Branches     1407     1407           
=======================================
  Hits         4614     4614           
+ Misses        406      404    -2     
- Partials        4        6    +2
Impacted Files Coverage Δ
components/transfer/index.tsx 87.41% <0%> (ø) ⬆️
components/time-picker/index.tsx 74.5% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e29a88b...73271a0. Read the comment docs.

yoyo837 added some commits Jul 24, 2018

@yesmeck

This comment has been minimized.

Member

yesmeck commented Jul 24, 2018

What's the problem does this PR try to resolve? Could you demonstrate it on codesandbox.io?

@yoyo837

This comment has been minimized.

Contributor

yoyo837 commented Jul 24, 2018

Yes, See https://codesandbox.io/s/q3m2pzqv1w
Vertical title is not aligned center with the icon.

@afc163 afc163 merged commit 5ca7d75 into ant-design:master Jul 27, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing e29a88b...73271a0
Details
codecov/project 91.83% remains the same compared to e29a88b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@yoyo837 yoyo837 deleted the yoyo837:vertical-label-content branch Jul 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment