New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Pagination Typescript definition to include "role" #11474

Merged
merged 2 commits into from Jul 27, 2018

Conversation

Projects
None yet
3 participants
@kagd
Contributor

kagd commented Jul 26, 2018

A PR on rc-pagination added the ability to define data-, aria- and role attributes. This PR is just adding the role attribute to the definition.

Definitions for data- and aria- are not required since they are already allowed as props on Pagination.

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jul 26, 2018

Deploy preview for ant-design ready!

Built with commit c8ef35d

https://deploy-preview-11474--ant-design.netlify.com

@yesmeck yesmeck merged commit fd06d7b into ant-design:master Jul 27, 2018

17 of 18 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@yesmeck

This comment has been minimized.

Member

yesmeck commented Jul 27, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment