New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onChange for Calendar #11476

Merged
merged 1 commit into from Jul 30, 2018

Conversation

Projects
None yet
3 participants
@tangjinzhou
Contributor

tangjinzhou commented Jul 27, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.
@ant-design-bot

This comment has been minimized.

ant-design-bot commented Jul 27, 2018

Deploy preview for ant-design ready!

Built with commit b5064a8

https://deploy-preview-11476--ant-design.netlify.com

@codecov

This comment has been minimized.

codecov bot commented Jul 27, 2018

Codecov Report

Merging #11476 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11476      +/-   ##
==========================================
+ Coverage   91.84%   91.85%   +<.01%     
==========================================
  Files         199      199              
  Lines        5030     5032       +2     
  Branches     1409     1410       +1     
==========================================
+ Hits         4620     4622       +2     
+ Misses        406      404       -2     
- Partials        4        6       +2
Impacted Files Coverage Δ
components/calendar/index.tsx 93.42% <100%> (+0.17%) ⬆️
components/time-picker/index.tsx 74.5% <0%> (ø) ⬆️
components/transfer/index.tsx 87.41% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee1c726...b5064a8. Read the comment docs.

@afc163 afc163 changed the base branch from master to feature-3.8.0 Jul 30, 2018

@afc163 afc163 merged commit 92dc0dc into ant-design:feature-3.8.0 Jul 30, 2018

20 checks passed

WIP ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 91.84%)
Details
codecov/project 91.85% (+<.01%) compared to ee1c726
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@tangjinzhou tangjinzhou deleted the tangjinzhou:calendar-change branch Jul 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment